Explicitly default Fabric to position: "static"
#41481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51182861 |
Base commit: 129bd9d |
|
This pull request was exported from Phabricator. Differential Revision: D51182861 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Pull Request resolved: facebook#41481 This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Differential Revision: D51182861 fbshipit-source-id: 4597a560c7b4794597c89a36b93184cc61f04b53
NickGerleman
force-pushed
the
export-D51182861
branch
from
e8137f7 to
82d336e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51182861 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 21, 2023
Summary: Pull Request resolved: facebook#41481 This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Reviewed By: sammy-SC Differential Revision: D51182861 fbshipit-source-id: 424b378603d83094bbaeaa5cf06175f12d52d66a
NickGerleman
force-pushed
the
export-D51182861
branch
from
82d336e to
a33432c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51182861 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 21, 2023
Summary: Pull Request resolved: facebook#41481 This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Reviewed By: sammy-SC Differential Revision: D51182861 fbshipit-source-id: 8188e9435d3110db6a6b70c273aea50968658826
NickGerleman
force-pushed
the
export-D51182861
branch
from
a33432c to
5fb3fac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51182861 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 22, 2023
Summary: Pull Request resolved: facebook#41481 This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Reviewed By: sammy-SC Differential Revision: D51182861 fbshipit-source-id: 706444495568b1f05811f44c55c130122cbcecff
NickGerleman
force-pushed
the
export-D51182861
branch
from
5fb3fac to
1983144
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51182861 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 25, 2023
Summary: Pull Request resolved: facebook#41481 This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Reviewed By: sammy-SC Differential Revision: D51182861 fbshipit-source-id: 96c29f8e02962055e4b03e83f25544f429ba8c04
NickGerleman
force-pushed
the
export-D51182861
branch
2 times, most recently
from
4930782 to
5a0cd44
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 26, 2023
Summary: This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Reviewed By: sammy-SC Differential Revision: D51182861
|
This pull request was exported from Phabricator. Differential Revision: D51182861 |
NickGerleman
force-pushed
the
export-D51182861
branch
from
5a0cd44 to
735110d
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 27, 2023
Summary: This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Reviewed By: sammy-SC Differential Revision: D51182861
|
This pull request was exported from Phabricator. Differential Revision: D51182861 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51182861 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 27, 2023
Summary: This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Reviewed By: sammy-SC Differential Revision: D51182861
NickGerleman
force-pushed
the
export-D51182861
branch
from
735110d to
9d326a6
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 28, 2023
Summary: This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Reviewed By: sammy-SC Differential Revision: D51182861
NickGerleman
force-pushed
the
export-D51182861
branch
from
9d326a6 to
4502a80
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51182861 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 28, 2023
Summary: This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D51182861
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 28, 2023
Summary: This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D51182861
NickGerleman
force-pushed
the
export-D51182861
branch
from
4502a80 to
345020a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51182861 |
NickGerleman
force-pushed
the
export-D51182861
branch
from
345020a to
f3e0e6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51182861 |
Summary: This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D51182861
NickGerleman
force-pushed
the
export-D51182861
branch
from
f3e0e6e to
7471f40
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 28, 2023
Summary: This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D51182861
|
This pull request was exported from Phabricator. Differential Revision: D51182861 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 28, 2023
Summary: This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D51182861
|
This pull request was successfully merged by @NickGerleman in fa436b4. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in fa436b4. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41481 This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D51182861 fbshipit-source-id: 25489d7f0642c4ff78340438c2b266e95a5fb207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This will allow us to keep RN on it's "pseudo-static" mode, while changing the Yoga default back to relative, to avoid breaking existing layouts.
Differential Revision: D51182861