[iOS] Remove duplicated category NSTextStorage+FontScaling #41437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 1891d9e |
|
@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: We have two same categories of `NSTextStorage+FontScaling`, another one is https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Text/Text/NSTextStorage%2BFontScaling.h. Only one category is valid, so we can delete one. ## Changelog: [IOS] [FIXED] - Remove duplicated category NSTextStorage+FontScaling Pull Request resolved: facebook#41437 Test Plan: Null. Reviewed By: rshest Differential Revision: D51253572 Pulled By: javache fbshipit-source-id: 4229351bf29699076d740defec64b61ea2151063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have two same categories of
NSTextStorage+FontScaling, another one is https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Text/Text/NSTextStorage%2BFontScaling.h. Only one category is valid, so we can delete one.Changelog:
[IOS] [FIXED] - Remove duplicated category NSTextStorage+FontScaling
Test Plan:
Null.