Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation warnings introduced by Gradle 8.4 #39959

Closed
wants to merge 3 commits into from
Closed

Fix compilation warnings introduced by Gradle 8.4 #39959

wants to merge 3 commits into from

Commits on Oct 6, 2023

  1. Un-bump AGP to 8.1.2 

    Summary:
I'm reverting the change of AGP from 8.2 beta to 8.1 as we don't need 8.2
Using 8.2 beta forces us to use Android Studio beta, which is actually not necessary.

Changelog:
[Android] [Changed] - Bump AGP to 8.1.2

Differential Revision: D50016572

fbshipit-source-id: 3d17079b21c967c4ced39e067f511a89f52c58b1
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    19ec74e View commit details
    Browse the repository at this point in the history

  2. Bump Gradle to 8.4 

    Summary:
This is our usual round of bumps just after the branch cut.

Changelog:
[Android] [Changed] - Bump Gradle to 8.4

Differential Revision: D50016574

fbshipit-source-id: d86bb071afc8afcb98cdba12e266f7d45e5ef6cd
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c799ee5 View commit details
    Browse the repository at this point in the history

  3. Fix compilation warnings introduced by Gradle 8.4 (facebook#39959) 

    Summary:
Pull Request resolved: facebook#39959

We're still accessing project.buildDir which will be removed in Gradle 9.0
I'm cleaning it up here.

Changelog:
[Internal] [Changed] - Fix compilation warnings introduced by Gradle 8.4

Reviewed By: yungsters

Differential Revision: D50016573

fbshipit-source-id: da026a56838a5d863a1a01cf710c0a06af4e0acf
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    4c76b99 View commit details
    Browse the repository at this point in the history