Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android Paper top-down onLayout events #39644

Closed
wants to merge 1 commit into from
Closed

Android Paper top-down onLayout events #39644

wants to merge 1 commit into from

Commits on Oct 3, 2023

  1. Top-down onLayout events (facebook#39644) 

    Summary:

This makes Android Paper/Classic renderer fire `onLayout` events top down, like in Fabric/new Architecture. This gives a much more sane model for using layout events to calculate bottom/right-edge insets.

I was under the impression that Paper in general was bottom-up, but it turns out that is only true for Android and Windows (iOS seems totally deterministic).

This is a behavior change, but to my knowledge was never hit during the Fabric migration, and any JS code already written for both Android and iOS cannot make assumptions here anyways.

Changelog:
[General][Changed] - Make layout events top-down on Android classic renderer

Reviewed By: mdvacca

Differential Revision: D49627996
    @NickGerleman @facebook-github-bot
    NickGerleman authored and facebook-github-bot committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    4034b3a View commit details
    Browse the repository at this point in the history