Make react-native use JSI headers from ReactCommon instead of the copy from Hermes tarball #38922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48152876 |
Base commit: 8fa584f |
|
This pull request was exported from Phabricator. Differential Revision: D48152876 |
dmytrorykun
force-pushed
the
export-D48152876
branch
from
67f3fff to
1b83472
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Aug 11, 2023
…y from Hermes tarball (facebook#38922) Summary: Pull Request resolved: facebook#38922 Changelog: [Internal] This diff alows react-native to use its own copy of JSI from `ReactCommom/jsi` instead of consuming headers vendored with Hermes. Reviewed By: NickGerleman Differential Revision: D48152876 fbshipit-source-id: a09cb75f607f787b291c2cf7c2de310e9379a185
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Aug 21, 2023
…y from Hermes tarball (facebook#38922) Summary: Pull Request resolved: facebook#38922 Changelog: [Internal] This diff alows react-native to use its own copy of JSI from `ReactCommom/jsi` instead of consuming headers vendored with Hermes. Reviewed By: NickGerleman Differential Revision: D48152876 fbshipit-source-id: fe262d56672d1ba8b1274752c2e8f53d39219953
dmytrorykun
force-pushed
the
export-D48152876
branch
from
1b83472 to
96552f6
Compare
…y from Hermes tarball (facebook#38922) Summary: Pull Request resolved: facebook#38922 Changelog: [Internal] This diff alows react-native to use its own copy of JSI from `ReactCommom/jsi` instead of consuming headers vendored with Hermes. Reviewed By: NickGerleman Differential Revision: D48152876 fbshipit-source-id: 7990017a2356a3c7942dc087704e65696ae1b3dd
dmytrorykun
force-pushed
the
export-D48152876
branch
from
96552f6 to
a32ee28
Compare
|
This pull request has been merged in a66ebc5. |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 15, 2023
…1499) Summary: After facebook#38922 we consume JSI from `ReactCommon/jsi`, and ignore JSI that is distributed with `hermes-engine`. This diff removes `include/jsi` from `source_files` of `hermes-engine` so we don't get two sets of JSI headers - one from `ReactCommon`, and the other one from `hermes-engine`. This diff also fixes accidental breakage of ODR violation, which was first fixed here facebook#35038 We will no longer compile JSI into `react-native` when linking against `hermes-engine`, which already has JSI in it. Changelog: [iOS][Fixed] - Exclude JSI headers when using hermes-engine prebuilt. Differential Revision: D51347562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This diff alows react-native to use its own copy of JSI from
ReactCommom/jsiinstead of consuming headers vendored with Hermes.Differential Revision: D48152876