Rename jSEngineInstance -> jsEngineInstance #38909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48051751 |
Base commit: 28dd1bb |
…eact.bridgeless Summary: in this diff I'm moving BridgelessReactPackage from com.facebook.react to com.facebook.react.bridgeless. the goal is to hide this class from the API changelog: [internal] internal Differential Revision: D48050453 fbshipit-source-id: c4c0e178b597feaea11c6797edbce0ea574d4b85
Summary: Make BridgelessReactPackage package only changelog: [internal] internal Differential Revision: D48050454 fbshipit-source-id: c061427440226c32c800a320f385b6e57e1ca7ba
Summary: Rename BridgelessReactPackage to CoreReactPackage changelog: [internal] internal Differential Revision: D48050452 fbshipit-source-id: 9cfcc4cde135c28540a19c8360e911e67f55cba7
Summary: Rename jSMainModulePath -> jsMainModulePath changelog: [internal] internal Differential Revision: D48051753 fbshipit-source-id: 51d74ad7c307dfe54e66855fba5da0d7bc31bba3
Summary: Pull Request resolved: facebook#38909 Rename jSEngineInstance -> jsEngineInstance changelog: [internal] internal Reviewed By: christophpurrer Differential Revision: D48051751 fbshipit-source-id: feee2898e260fe944fe0b5a8a99f9456af3851cf
mdvacca
force-pushed
the
export-D48051751
branch
from
e2b8d00 to
7ee0895
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48051751 |
|
This pull request has been merged in e2ef6b9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Rename jSEngineInstance -> jsEngineInstance
changelog: [internal] internal
Reviewed By: christophpurrer
Differential Revision: D48051751