-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable partial media picking in Marketplace #38880
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
fb-exported
labels
Aug 9, 2023
This pull request was exported from Phabricator. Differential Revision: D48171193 |
Base commit: c956a1b |
Summary: Pull Request resolved: facebook#38880 Users who interact with your app on Android 14 devices can now grant partial access to their visual media library (Photos/Videos) when an app requests any visual media permissions (READ_MEDIA_IMAGES or READ_MEDIA_VIDEO) introduced in Android 13 (API level 33). This diff allow enable the partial access via "READ_MEDIA_VISUAL_USER_SELECTED" in Marketplace photo picker For Android 14 this diff request partial media access plus the normal access, there will be two return cases: - READ_MEDIA_VISUAL_USER_SELECTED is granted, READ_MEDIA_IMAGES and READ_MEDIA_VIDEO will be denied automatically, there is no need to check the later ones - READ_MEDIA_VISUAL_USER_SELECTED is denied, then check READ_MEDIA_IMAGES and READ_MEDIA_VIDEO Changelog: [Android][Changed] - Enable partial media picking in Marketplace Reviewed By: NickGerleman Differential Revision: D48171193 fbshipit-source-id: 6e8d022a81b2e32108cd57b30ad5ce148be17c5a
luluwu2032
force-pushed
the
export-D48171193
branch
from
August 9, 2023 11:17
044ecb7
to
372575c
Compare
This pull request was exported from Phabricator. Differential Revision: D48171193 |
This pull request has been merged in 72b9516. |
luluwu2032
added a commit
to luluwu2032/react-native
that referenced
this pull request
Sep 20, 2023
Summary: In facebook#38880 we added the new media permission "READ_MEDIA_VISUAL_USER_SELECTED", this diff added it for TS as well Reviewed By: NickGerleman, mdvacca Differential Revision: D49371798
ShevO27
pushed a commit
to ShevO27/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39563 In facebook#38880 we added the new media permission "READ_MEDIA_VISUAL_USER_SELECTED", this diff added it for TS as well Reviewed By: NickGerleman, mdvacca Differential Revision: D49371798 fbshipit-source-id: ebc77872f5609b411904b04e684b804584eeaaa9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Users who interact with your app on Android 14 devices can now grant partial access to their visual media library (Photos/Videos) when an app requests any visual media permissions (READ_MEDIA_IMAGES or READ_MEDIA_VIDEO) introduced in Android 13 (API level 33).
This diff allow enable the partial access via "READ_MEDIA_VISUAL_USER_SELECTED" in Marketplace photo picker
For Android 14 this diff request partial media access plus the normal access, there will be two return cases:
Reviewed By: NickGerleman
Differential Revision: D48171193