Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ReactImagePropertyList to kotlin #38845

Closed
wants to merge 3 commits into from
Closed

Convert ReactImagePropertyList to kotlin #38845

wants to merge 3 commits into from

Conversation

bufgix
Copy link
Contributor

@bufgix bufgix commented Aug 8, 2023

Summary:

Issue: #38825 (comment)

Changelog:

[GENERAL] [CHANGED] - ReactImagePropertyList.java => ReactImagePropertyList.kt

Test Plan:

./gradlew :packages:react-native:ReactAndroid:test

@analysis-bot
Copy link

analysis-bot commented Aug 8, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,894,950 +10
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,486,848 +4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 1d87279
Branch: main

@facebook-github-bot
Copy link
Contributor

Hi @bufgix!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@cortinico
Copy link
Contributor

Hey @bufgix
Could you accept our CLA? We can't merge code from contributors which don't accept it otherwise.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 8, 2023
mdvacca
mdvacca reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@mdvacca mdvacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this PR, added just few small comments

...t-native/ReactAndroid/src/test/java/com/facebook/react/views/image/ReactImagePropertyTest.kt Outdated

@get:Rule var rule = PowerMockRule()

private var mContext: ReactApplicationContext? = null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's replace mContext -> context

...t-native/ReactAndroid/src/test/java/com/facebook/react/views/image/ReactImagePropertyTest.kt Outdated
@get:Rule var rule = PowerMockRule()

private var mContext: ReactApplicationContext? = null
private var mCatalystInstanceMock: CatalystInstance? = null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's replace mCatalystInstanceMock -> catalystInstanceMock

...t-native/ReactAndroid/src/test/java/com/facebook/react/views/image/ReactImagePropertyTest.kt Outdated

private var mContext: ReactApplicationContext? = null
private var mCatalystInstanceMock: CatalystInstance? = null
private var mThemeContext: ThemedReactContext? = null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: let's replace mThemeContext -> themeContext

...t-native/ReactAndroid/src/test/java/com/facebook/react/views/image/ReactImagePropertyTest.kt Outdated
DisplayMetricsHolder.setWindowDisplayMetrics(null)
}

fun buildStyles(vararg keysAndValues: Any?): ReactStylesDiffMap {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: let's make this method private

@facebook-github-bot
Copy link
Contributor

@mdvacca has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 9, 2023
@facebook-github-bot
Copy link
Contributor

@mdvacca merged this pull request in cb60e5c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdvacca mdvacca mdvacca left review comments

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bufgix @analysis-bot @facebook-github-bot @cortinico @mdvacca