Fix regression with NativeSyntheticEvent and add test. #38600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
gentle ping to @NickGerleman and @lunaleaps |
|
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NickGerleman
approved these changes
Jul 25, 2023
|
@lunaleaps merged this pull request in fedad15. |
This was referenced Jul 25, 2023
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: With moving the TypeScript declarations into the repo, the NativeSyntheticEvent type was copied incorrectly from DefinitelyTyped. This was the old one: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/v0.70/index.d.ts#L355 ## Changelog: [GENERAL] [FIXED] - Correct the NativeSyntheticEvent type Pull Request resolved: facebook#38600 Test Plan: Added a test and ran `yarn test-typescript` Reviewed By: NickGerleman Differential Revision: D47739191 Pulled By: lunaleaps fbshipit-source-id: 0c8b51a62f589a716121e9bfa8ce7e6103f37f6b
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: With moving the TypeScript declarations into the repo, the NativeSyntheticEvent type was copied incorrectly from DefinitelyTyped. This was the old one: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/v0.70/index.d.ts#L355 ## Changelog: [GENERAL] [FIXED] - Correct the NativeSyntheticEvent type Pull Request resolved: facebook#38600 Test Plan: Added a test and ran `yarn test-typescript` Reviewed By: NickGerleman Differential Revision: D47739191 Pulled By: lunaleaps fbshipit-source-id: 0c8b51a62f589a716121e9bfa8ce7e6103f37f6b
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: With moving the TypeScript declarations into the repo, the NativeSyntheticEvent type was copied incorrectly from DefinitelyTyped. This was the old one: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/v0.70/index.d.ts#L355 ## Changelog: [GENERAL] [FIXED] - Correct the NativeSyntheticEvent type Pull Request resolved: facebook#38600 Test Plan: Added a test and ran `yarn test-typescript` Reviewed By: NickGerleman Differential Revision: D47739191 Pulled By: lunaleaps fbshipit-source-id: 0c8b51a62f589a716121e9bfa8ce7e6103f37f6b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With moving the TypeScript declarations into the repo, the NativeSyntheticEvent type was copied incorrectly from DefinitelyTyped.
This was the old one: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/v0.70/index.d.ts#L355
Changelog:
[GENERAL] [FIXED] - Correct the NativeSyntheticEvent type
Test Plan:
Added a test and ran
yarn test-typescript