Android: expose ReactFontManager as a standalone target #38506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47569319 |
fkgozali
force-pushed
the
export-D47569319
branch
from
35fef88 to
be0932e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47569319 |
Base commit: cb173e6 |
|
This pull request was exported from Phabricator. Differential Revision: D47569319 |
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Jul 19, 2023
Summary: Pull Request resolved: facebook#38506 There are use cases where an app needs to install a custom font in a separate infra/tool. Instead of bloating those infra/tool with deep React Native dependencies, this allows it to depend on only the pieces that matter. To ensure backward compatibility, the existing ReactFontManager will proxy method calls to the new impl going forward. Changelog: [Changed][Android] Moved ReactFontManager to a common package Reviewed By: mdvacca Differential Revision: D47569319 fbshipit-source-id: e3fb8f44715c2889b7703f77f7cb933c0a541cf0
fkgozali
force-pushed
the
export-D47569319
branch
from
be0932e to
d4f3dbd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47569319 |
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Jul 19, 2023
Summary: Pull Request resolved: facebook#38506 There are use cases where an app needs to install a custom font in a separate infra/tool. Instead of bloating those infra/tool with deep React Native dependencies, this allows it to depend on only the pieces that matter. To ensure backward compatibility, the existing ReactFontManager will proxy method calls to the new impl going forward. Changelog: [Changed][Android] Moved ReactFontManager to a common package Reviewed By: mdvacca Differential Revision: D47569319 fbshipit-source-id: 1346b254c9e1ce7778c0a9b7c541cf7110cab67a
fkgozali
force-pushed
the
export-D47569319
branch
from
d4f3dbd to
6916316
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47569319 |
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Jul 19, 2023
Summary: Pull Request resolved: facebook#38506 There are use cases where an app needs to install a custom font in a separate infra/tool. Instead of bloating those infra/tool with deep React Native dependencies, this allows it to depend on only the pieces that matter. To ensure backward compatibility, the existing ReactFontManager will proxy method calls to the new impl going forward. Changelog: [Changed][Android] Moved ReactFontManager to a common package Reviewed By: mdvacca Differential Revision: D47569319 fbshipit-source-id: fecf8368d1315639df7fd1f2975249efc5d145a9
fkgozali
force-pushed
the
export-D47569319
branch
from
6916316 to
67a3fe1
Compare
Summary: Pull Request resolved: facebook#38506 There are use cases where an app needs to install a custom font in a separate infra/tool. Instead of bloating those infra/tool with deep React Native dependencies, this allows it to depend on only the pieces that matter. To ensure backward compatibility, the existing ReactFontManager will proxy method calls to the new impl going forward. Changelog: [Changed][Android] Moved ReactFontManager to a common package Reviewed By: mdvacca Differential Revision: D47569319 fbshipit-source-id: e8e715bfe3b02723345eb90a7e6fa8247f7b13ac
fkgozali
force-pushed
the
export-D47569319
branch
from
67a3fe1 to
75d09b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47569319 |
|
This pull request was successfully merged by @fkgozali in 7341f9a. When will my fix make it into a release? | Upcoming Releases |
juniorklawa
pushed a commit
to juniorklawa/react-native
that referenced
this pull request
Jul 20, 2023
Summary: Pull Request resolved: facebook#38506 There are use cases where an app needs to install a custom font in a separate infra/tool. Instead of bloating those infra/tool with deep React Native dependencies, this allows it to depend on only the pieces that matter. To ensure backward compatibility, the existing ReactFontManager will proxy method calls to the new impl going forward. Changelog: [Changed][Android] Moved ReactFontManager to a common package Reviewed By: mdvacca Differential Revision: D47569319 fbshipit-source-id: 18ba6617d6c3f68823bdccaacfd8cc961cd6ce34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There are use cases where an app needs to install a custom font in a separate infra/tool. Instead of bloating those infra/tool with deep React Native dependencies, this allows it to depend on only the pieces that matter.
To ensure backward compatibility, the existing ReactFontManager will proxy method calls to the new impl going forward.
Changelog: [Changed][Android] Moved ReactFontManager to a common package
Differential Revision: D47569319