Fix builds with C++20 #38501
Closed
Fix builds with C++20 #38501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47537998 |
Base commit: c0b04d6 |
smeenai
added a commit
to smeenai/react-native
that referenced
this pull request
Jul 18, 2023
Summary: Pull Request resolved: facebook#38501 char8_t is a distinct type in C++20, which would need to be propagated everywhere else (e.g. using `std::u8string` instead of `std::string`). The code was already assuming that char is UTF-8, so we can just cast accordingly (which works on all compilers: https://godbolt.org/z/9cv4c48o4). Reviewed By: javache Differential Revision: D47537998 fbshipit-source-id: d652188d8373e529d0be891036cce626138605c0
smeenai
force-pushed
the
export-D47537998
branch
from
4c5a633 to
caace7e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47537998 |
Summary: Pull Request resolved: facebook#38501 char8_t is a distinct type in C++20, which would need to be propagated everywhere else (e.g. using `std::u8string` instead of `std::string`). The code was already assuming that char is UTF-8, so we can just cast accordingly (which works on all compilers: https://godbolt.org/z/9cv4c48o4). Reviewed By: javache Differential Revision: D47537998 fbshipit-source-id: c56b13e1b45fcb20aaeea8c523d29c85cf43fbe0
|
This pull request was exported from Phabricator. Differential Revision: D47537998 |
github-actions
bot
added
the
Needs: Repro
smeenai
force-pushed
the
export-D47537998
branch
from
caace7e to
86521ab
Compare
|
This pull request was successfully merged by @smeenai in 2d3348e. When will my fix make it into a release? | Upcoming Releases |
cortinico
removed
the
Needs: Repro
juniorklawa
pushed a commit
to juniorklawa/react-native
that referenced
this pull request
Jul 20, 2023
Summary: Pull Request resolved: facebook#38501 char8_t is a distinct type in C++20, which would need to be propagated everywhere else (e.g. using `std::u8string` instead of `std::string`). The code was already assuming that char is UTF-8, so we can just cast accordingly (which works on all compilers: https://godbolt.org/z/9cv4c48o4). Reviewed By: javache Differential Revision: D47537998 fbshipit-source-id: ba045483361463f1754e02791114b78f51932a56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
char8_t is a distinct type in C++20, which would need to be propagated
everywhere else (e.g. using
std::u8stringinstead ofstd::string).The code was already assuming that char is UTF-8, so we can just cast
accordingly (which works on all compilers: https://godbolt.org/z/9cv4c48o4).
Reviewed By: javache
Differential Revision: D47537998