Remove run Metro hook from Xcode build, remove launchPackager scripts #38242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47297469 |
Base commit: c82f2e9 |
…facebook#38242) Summary: Pull Request resolved: facebook#38242 See proposal: react-native-community/discussions-and-proposals#681 **Removed script files** I searched GitHub (and specifically `react-native-windows/macos`) to confirm these files are not referenced: - `scripts/launchPackager.bat` - `scripts/launchPackager.command` - `scripts/.packager.env` Interestingly, React Native CLI refers to a `.packager.env` at a different location (`node_modules/.bin/`), and includes modified copies of `launchPackager.command/bat`. This PR removes duplication with these. Changelog: [iOS][Breaking] Metro will no longer be started when running builds via Xcode Reviewed By: cortinico Differential Revision: D47297469 fbshipit-source-id: 8edd7934c91250416ea13348821dc08905c6ca50
|
This pull request was exported from Phabricator. Differential Revision: D47297469 |
|
This pull request was successfully merged by @huntie in dc68457. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in dc68457. |
EvanBacon
added a commit
to expo/expo
that referenced
this pull request
Oct 31, 2023
# Why - Aligns with upstream React Native facebook/react-native#38242 - react-native-community/discussions-and-proposals#681 - "Fix" monorepo issues ENG-10051 # How - Remove script from templates. - Drop unused files. --------- Co-authored-by: Expo Bot <[email protected]>
Merged
10 tasks
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
… (#38242) Summary: Pull Request resolved: facebook/react-native#38242 See proposal: react-native-community/discussions-and-proposals#681 **Removed script files** I searched GitHub (and specifically `react-native-windows/macos`) to confirm these files are not referenced: - `scripts/launchPackager.bat` - `scripts/launchPackager.command` - `scripts/.packager.env` Interestingly, React Native CLI refers to a `.packager.env` at a different location (`node_modules/.bin/`), and includes modified copies of `launchPackager.command/bat`. This PR removes duplication with these. Changelog: [iOS][Breaking] Metro will no longer be started when running builds via Xcode Reviewed By: cortinico Differential Revision: D47297469 fbshipit-source-id: 06c3602d58b21ed693c3daa763d99947a70bfc5a Original: facebook/react-native@dc68457
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
… (#38242) Summary: Pull Request resolved: facebook/react-native#38242 See proposal: react-native-community/discussions-and-proposals#681 **Removed script files** I searched GitHub (and specifically `react-native-windows/macos`) to confirm these files are not referenced: - `scripts/launchPackager.bat` - `scripts/launchPackager.command` - `scripts/.packager.env` Interestingly, React Native CLI refers to a `.packager.env` at a different location (`node_modules/.bin/`), and includes modified copies of `launchPackager.command/bat`. This PR removes duplication with these. Changelog: [iOS][Breaking] Metro will no longer be started when running builds via Xcode Reviewed By: cortinico Differential Revision: D47297469 fbshipit-source-id: 06c3602d58b21ed693c3daa763d99947a70bfc5a Original-Commit: facebook/react-native@dc68457
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
… (#38242) Summary: Pull Request resolved: facebook/react-native#38242 See proposal: react-native-community/discussions-and-proposals#681 **Removed script files** I searched GitHub (and specifically `react-native-windows/macos`) to confirm these files are not referenced: - `scripts/launchPackager.bat` - `scripts/launchPackager.command` - `scripts/.packager.env` Interestingly, React Native CLI refers to a `.packager.env` at a different location (`node_modules/.bin/`), and includes modified copies of `launchPackager.command/bat`. This PR removes duplication with these. Changelog: [iOS][Breaking] Metro will no longer be started when running builds via Xcode Reviewed By: cortinico Differential Revision: D47297469 fbshipit-source-id: 06c3602d58b21ed693c3daa763d99947a70bfc5a Original-Commit: facebook/react-native@dc68457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See proposal: react-native-community/discussions-and-proposals#681
Removed script files
I searched GitHub (and specifically
react-native-windows/macos) to confirm these files are not referenced:scripts/launchPackager.batscripts/launchPackager.commandscripts/.packager.envInterestingly, React Native CLI refers to a
.packager.envat a different location (node_modules/.bin/), and includes modified copies oflaunchPackager.command/bat. This PR removes duplication with these.Changelog: [iOS][Breaking] Metro will no longer be started when running builds via Xcode
Differential Revision: D47297469