Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update globals.d.ts for Blob.slice() contentType declaration #38163

Closed
wants to merge 1 commit into from
Closed

Update globals.d.ts for Blob.slice() contentType declaration #38163

wants to merge 1 commit into from

Conversation

trashcoder
Copy link
Contributor

@trashcoder trashcoder commented Jul 3, 2023

Summary:

For the contentType Parameter of the method slice in Class Blob which was fixed for
#38078
the typescript declaration is missing.

Changelog:

[GENERAL] [ADDED] - Added contentType parameter to Blob declaration

Test Plan:

I ran yarn run test-typescript and check with Webstorm and VSCode.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 3, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,047,667 +1
android hermes armeabi-v7a 8,297,084 +2
android hermes x86 9,563,961 +2
android hermes x86_64 9,406,116 -1
android jsc arm64-v8a 9,606,384 +1
android jsc armeabi-v7a 8,733,108 +0
android jsc x86 9,693,421 +0
android jsc x86_64 9,939,709 -1

Base commit: f90829f
Branch: main

@trashcoder

This comment was marked as resolved.

@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 6, 2023
@facebook-github-bot
Copy link
Contributor

@javache merged this pull request in ff40138.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants