Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused mapException methods #38042

Closed
wants to merge 1 commit into from

Conversation

javache
Copy link
Member

@javache javache commented Jun 23, 2023

Summary:
Follow-up cleanup from D34379950, now that fbjni has been upgraded. Also synced the internal and external build flags.

Changelog: [Internal]

Differential Revision: D46975010

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 23, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46975010

javache added a commit to javache/react-native that referenced this pull request Jun 23, 2023
Summary:
Pull Request resolved: facebook#38042

Follow-up cleanup from D34379950, now that fbjni has been upgraded. Also synced the internal and external build flags.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D46975010

fbshipit-source-id: da068ea7964e2d9c116faa916908fa203b8d0f36
@javache javache force-pushed the export-D46975010 branch from 9f3abc4 to d1a0b11 Compare June 23, 2023 17:04
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46975010

@analysis-bot
Copy link

analysis-bot commented Jun 23, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,041,886 +40,298
android hermes armeabi-v7a 8,292,531 +30,363
android hermes x86 9,558,995 +44,010
android hermes x86_64 9,400,619 +42,873
android jsc arm64-v8a 9,601,069 +40,502
android jsc armeabi-v7a 8,729,051 +30,586
android jsc x86 9,689,074 +44,238
android jsc x86_64 9,934,778 +43,095

Base commit: 85666e4
Branch: main

javache added a commit to javache/react-native that referenced this pull request Jun 26, 2023
Summary:
Pull Request resolved: facebook#38042

Follow-up cleanup from D34379950, now that fbjni has been upgraded. Also synced the internal and external build flags.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D46975010

fbshipit-source-id: 55793616c3bd021f0cce733d1a5bd398acf1ec95
@javache javache force-pushed the export-D46975010 branch from d1a0b11 to aabacea Compare June 26, 2023 09:16
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46975010

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46975010

javache added a commit to javache/react-native that referenced this pull request Jun 26, 2023
Summary:
Pull Request resolved: facebook#38042

Follow-up cleanup from D34379950, now that fbjni has been upgraded. Also synced the internal and external build flags.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D46975010

fbshipit-source-id: 0e70b8b98f0d519523cf6c85628d66ba33a83a49
@javache javache force-pushed the export-D46975010 branch from aabacea to c38077e Compare June 26, 2023 09:26
javache added a commit to javache/react-native that referenced this pull request Jun 26, 2023
Summary:
Pull Request resolved: facebook#38042

Follow-up cleanup from D34379950, now that fbjni has been upgraded. Also synced the internal and external build flags.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D46975010

fbshipit-source-id: 6bf6b15571fc8fd767bca88c6882f4cfc2603ab7
@javache javache force-pushed the export-D46975010 branch from c38077e to 41e8b6e Compare June 26, 2023 10:00
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46975010

javache added a commit to javache/react-native that referenced this pull request Jun 26, 2023
Summary:
Pull Request resolved: facebook#38042

Follow-up cleanup from D34379950, now that fbjni has been upgraded. Also synced the internal and external build flags.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D46975010

fbshipit-source-id: 760b04a5d23e18767223b24dc2ed94550fe754f6
@javache javache force-pushed the export-D46975010 branch from 41e8b6e to 64c9f78 Compare June 26, 2023 10:10
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46975010

javache added a commit to javache/react-native that referenced this pull request Jun 26, 2023
Summary:
Pull Request resolved: facebook#38042

Follow-up cleanup from D34379950, now that fbjni has been upgraded. Also synced the internal and external build flags.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D46975010

fbshipit-source-id: fda3984e226c6537e9c3bbed65e0bfd5c000c713
@javache javache force-pushed the export-D46975010 branch from 64c9f78 to b94fe38 Compare June 26, 2023 10:19
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46975010

javache added a commit to javache/react-native that referenced this pull request Jun 26, 2023
Summary:
Pull Request resolved: facebook#38042

Follow-up cleanup from D34379950, now that fbjni has been upgraded. Also synced the internal and external build flags.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D46975010

fbshipit-source-id: 26e8eb9cbd50ee139052d567e58e1fb180288542
@javache javache force-pushed the export-D46975010 branch from b94fe38 to 7732f80 Compare June 26, 2023 10:48
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46975010

Summary:
Pull Request resolved: facebook#38042

Follow-up cleanup from D34379950, now that fbjni has been upgraded. Also synced the internal and external build flags.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D46975010

fbshipit-source-id: dc557883aadc8ff3e2fef665571b9029a316c3d0
@javache javache force-pushed the export-D46975010 branch from 7732f80 to 5cfeff6 Compare June 26, 2023 10:56
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46975010

@github-actions
Copy link

This pull request was successfully merged by @javache in 772c9eb.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Jun 26, 2023
@javache javache deleted the export-D46975010 branch June 26, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants