Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onChangeText not firing when clearing the value of TextInput with multiline=true on iOS #37957

Closed
wants to merge 1 commit into from
Closed

Fix onChangeText not firing when clearing the value of TextInput with multiline=true on iOS #37957

wants to merge 1 commit into from

Conversation

kkoudev
Copy link
Contributor

@kkoudev kkoudev commented Jun 19, 2023

Summary:

This fix fixes the TextInput issue in #37784 with onChangeText not working on iOS only.

Changelog:

[IOS] [FIXED] - Fix onChangeText not firing when clearing the value of TextInput with multiline=true on iOS

Test Plan:

  1. Run the repro code given in the issue (When multiline=true, TextInput's onChangeText() callback may not fire. #37784).
  2. Verified that onChangeText works after pressing the submit button.
  3. Run the repro code from the issue (TextInput onChangeText called automatically for maxLength and multiline #36494) that caused this issue.
  4. Verified that issue (TextInput onChangeText called automatically for maxLength and multiline #36494) is not reoccurring.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 19, 2023
@kkoudev kkoudev closed this Jun 19, 2023
@kkoudev kkoudev deleted the fix-textinput-multiline-onchangetext branch June 19, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants