Switch xplat prettier config to hermes plugin #37915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Enable the `prettier-plugin-hermes-parser` in xplat. This plugin enables the use of `hermes-parser` which is significantly faster than the current flow parser prettier bundles (improves formatting time by ~50%) and also brings support for the latest Prettier 3.0.0 printing logic for JS. This upgrade is required in order to enable upcoming Flow features that add new syntax. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D46748891 fbshipit-source-id: e162e498bb5a7c2855bfe2e0151694d8518213c4
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46748891 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -246,7 +246,18 @@ const ScrollViewStickyHeaderWithForwardedRef: React.AbstractComponent< | |||
| clearTimeout(_timer.current); | |||
| } | |||
| }; | |||
| }, [nextHeaderLayoutY, measured, layoutHeight, layoutY, scrollViewHeight, scrollAnimatedValue, inverted, offset, animatedValueListener, isFabric]); | |||
| }, [ | |||
There was a problem hiding this comment.
- 🚫 packages/react-native/Libraries/Components/ScrollView/ScrollViewStickyHeader.js line 249 – Replace
⏎····nextHeaderLayoutY,⏎····measured,⏎····layoutHeight,⏎····layoutY,⏎····scrollViewHeight,⏎····scrollAnimatedValue,⏎····inverted,⏎····offset,⏎····animatedValueListener,⏎····isFabric,⏎··withnextHeaderLayoutY,·measured,·layoutHeight,·layoutY,·scrollViewHeight,·scrollAnimatedValue,·inverted,·offset,·animatedValueListener,·isFabric(prettier/prettier)
| @@ -22,8 +22,10 @@ let hasNativeGenerator; | |||
| try { | |||
| // If this function was lowered by regenerator-transform, it will try to | |||
| // access `global.regeneratorRuntime` which doesn't exist yet and will throw. | |||
| hasNativeGenerator = hasNativeConstructor(function* () {}, | |||
| 'GeneratorFunction'); | |||
| hasNativeGenerator = hasNativeConstructor( | |||
There was a problem hiding this comment.
- 🚫 packages/react-native/Libraries/Core/setUpRegeneratorRuntime.js line 25 – Delete
⏎····(prettier/prettier)
| 'GeneratorFunction'); | ||
| hasNativeGenerator = hasNativeConstructor( | ||
| function* () {}, | ||
| 'GeneratorFunction', |
There was a problem hiding this comment.
- 🚫 packages/react-native/Libraries/Core/setUpRegeneratorRuntime.js line 27 – Replace
····'GeneratorFunction',⏎··with··'GeneratorFunction'(prettier/prettier)
| @@ -88,7 +88,7 @@ const backgroundForLevel = (level: LogLevel) => | |||
| default: 'transparent', | |||
| pressed: LogBoxStyle.getFatalDarkColor(), | |||
| }, | |||
| }[level]); | |||
| })[level]; | |||
There was a problem hiding this comment.
- 🚫 packages/react-native/Libraries/LogBox/UI/LogBoxInspectorHeader.js line 91 – Replace
)[level]with[level])(prettier/prettier)
| )} to ensure you're always using the most current version of the CLI. NPX has cached version (${chalk.bold.yellow( | ||
| currentVersion, | ||
| )}) != current release (${chalk.bold.green(latest)}) | ||
| 'npx react-native@latest', |
There was a problem hiding this comment.
- 🚫 packages/react-native/cli.js line 59 – Insert
······(prettier/prettier)
| 'event should have the right type', | ||
| ); | ||
| assert_equals( | ||
| isPrimary, |
There was a problem hiding this comment.
- 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 78 – Delete
··(prettier/prettier)
| ); | ||
| assert_equals( | ||
| isPrimary, | ||
| expectedIsPrimary, |
There was a problem hiding this comment.
- 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 79 – Delete
··(prettier/prettier)
| assert_equals( | ||
| isPrimary, | ||
| expectedIsPrimary, | ||
| 'event should be correctly primary', |
There was a problem hiding this comment.
- 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 80 – Delete
··(prettier/prettier)
| isPrimary, | ||
| expectedIsPrimary, | ||
| 'event should be correctly primary', | ||
| ); |
There was a problem hiding this comment.
- 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 81 – Delete
··(prettier/prettier)
| expectedIsPrimary, | ||
| 'event should be correctly primary', | ||
| ); | ||
| }, |
There was a problem hiding this comment.
- 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 82 – Replace
··},⏎········${expectedBoxLabel}·box's·${expectedEventType}·should${⏎··········!expectedIsPrimary·?·'·not'·:·''⏎········}·be·marked·as·the·primary·pointer,⏎······with},·${expectedBoxLabel}·box's·${expectedEventType}·should${!expectedIsPrimary·?·'·not'·:·''}·be·marked·as·the·primary·pointer`` (prettier/prettier)
| @@ -246,7 +246,18 @@ const ScrollViewStickyHeaderWithForwardedRef: React.AbstractComponent< | |||
| clearTimeout(_timer.current); | |||
| } | |||
| }; | |||
| }, [nextHeaderLayoutY, measured, layoutHeight, layoutY, scrollViewHeight, scrollAnimatedValue, inverted, offset, animatedValueListener, isFabric]); | |||
| }, [ | |||
There was a problem hiding this comment.
- 🚫 packages/react-native/Libraries/Components/ScrollView/ScrollViewStickyHeader.js line 249 – Replace
⏎····nextHeaderLayoutY,⏎····measured,⏎····layoutHeight,⏎····layoutY,⏎····scrollViewHeight,⏎····scrollAnimatedValue,⏎····inverted,⏎····offset,⏎····animatedValueListener,⏎····isFabric,⏎··withnextHeaderLayoutY,·measured,·layoutHeight,·layoutY,·scrollViewHeight,·scrollAnimatedValue,·inverted,·offset,·animatedValueListener,·isFabric(prettier/prettier)
| @@ -22,8 +22,10 @@ let hasNativeGenerator; | |||
| try { | |||
| // If this function was lowered by regenerator-transform, it will try to | |||
| // access `global.regeneratorRuntime` which doesn't exist yet and will throw. | |||
| hasNativeGenerator = hasNativeConstructor(function* () {}, | |||
| 'GeneratorFunction'); | |||
| hasNativeGenerator = hasNativeConstructor( | |||
There was a problem hiding this comment.
- 🚫 packages/react-native/Libraries/Core/setUpRegeneratorRuntime.js line 25 – Delete
⏎····(prettier/prettier)
| 'GeneratorFunction'); | ||
| hasNativeGenerator = hasNativeConstructor( | ||
| function* () {}, | ||
| 'GeneratorFunction', |
There was a problem hiding this comment.
- 🚫 packages/react-native/Libraries/Core/setUpRegeneratorRuntime.js line 27 – Replace
····'GeneratorFunction',⏎··with··'GeneratorFunction'(prettier/prettier)
| @@ -88,7 +88,7 @@ const backgroundForLevel = (level: LogLevel) => | |||
| default: 'transparent', | |||
| pressed: LogBoxStyle.getFatalDarkColor(), | |||
| }, | |||
| }[level]); | |||
| })[level]; | |||
There was a problem hiding this comment.
- 🚫 packages/react-native/Libraries/LogBox/UI/LogBoxInspectorHeader.js line 91 – Replace
)[level]with[level])(prettier/prettier)
| )} to ensure you're always using the most current version of the CLI. NPX has cached version (${chalk.bold.yellow( | ||
| currentVersion, | ||
| )}) != current release (${chalk.bold.green(latest)}) | ||
| 'npx react-native@latest', |
There was a problem hiding this comment.
- 🚫 packages/react-native/cli.js line 59 – Insert
······(prettier/prettier)
| 'event should have the right type', | ||
| ); | ||
| assert_equals( | ||
| isPrimary, |
There was a problem hiding this comment.
- 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 78 – Delete
··(prettier/prettier)
| ); | ||
| assert_equals( | ||
| isPrimary, | ||
| expectedIsPrimary, |
There was a problem hiding this comment.
- 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 79 – Delete
··(prettier/prettier)
| assert_equals( | ||
| isPrimary, | ||
| expectedIsPrimary, | ||
| 'event should be correctly primary', |
There was a problem hiding this comment.
- 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 80 – Delete
··(prettier/prettier)
| isPrimary, | ||
| expectedIsPrimary, | ||
| 'event should be correctly primary', | ||
| ); |
There was a problem hiding this comment.
- 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 81 – Delete
··(prettier/prettier)
| expectedIsPrimary, | ||
| 'event should be correctly primary', | ||
| ); | ||
| }, |
There was a problem hiding this comment.
- 🚫 packages/rn-tester/js/examples/Experimental/W3CPointerEventPlatformTests/PointerEventPrimaryTouchPointer.js line 82 – Replace
··},⏎········${expectedBoxLabel}·box's·${expectedEventType}·should${⏎··········!expectedIsPrimary·?·'·not'·:·''⏎········}·be·marked·as·the·primary·pointer,⏎······with},·${expectedBoxLabel}·box's·${expectedEventType}·should${!expectedIsPrimary·?·'·not'·:·''}·be·marked·as·the·primary·pointer`` (prettier/prettier)
|
This pull request was successfully merged by @pieterv in dc2037c. When will my fix make it into a release? | Upcoming Releases |
Base commit: 54a5ff9 |
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Jun 15, 2023
Summary: X-link: facebook/react-native#37915 Enable the `prettier-plugin-hermes-parser` in xplat. This plugin enables the use of `hermes-parser` which is significantly faster than the current flow parser prettier bundles (improves formatting time by ~50%) and also brings support for the latest Prettier 3.0.0 printing logic for JS. This upgrade is required in order to enable upcoming Flow features that add new syntax. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D46748891 fbshipit-source-id: 3775ef9afa7c04e565fa4fcf8ca5b410f49d35a1
adamaveray
added a commit
to adamaveray/react-native
that referenced
this pull request
Jun 16, 2023
* main: (135 commits) translation auto-update for i18n/twilight.config.json on master Interop: Introduce Bridge proxy Remove okhttp internal util usage (facebook#37843) Update debian to fix CI while updating Node (facebook#37841) fix: foreground ripple crash on api < 23 (facebook#37901) Re-add the top level LICENSE file (facebook#37916) Deploy 0.209.0 to xplat (facebook#37921) Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37914) add emitObjectProp in parser primitives (facebook#37904) Make React-utils its own pod (facebook#37659) feat: allow custom assignment of rootView to rootViewController (facebook#37873) Switch xplat prettier config to hermes plugin (facebook#37915) Set iOS AppState to inactive when app is launching (facebook#37690) Use `fileExists` in replace_hermes script (facebook#37911) (docs): fix license url (facebook#37909) Revert D46719890: Re-enable direct debugging with JSC on iOS 16.4+ Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37874) Fix component type references in xplat (facebook#37903) Remove usage of passthroughAnimatedPropExplicitValues in ScrollViewStickyHeader (facebook#37867) test runtime lifecycle callback (facebook#37897) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enable the
prettier-plugin-hermes-parserin xplat. This plugin enables the use ofhermes-parserwhich is significantly faster than the current flow parser prettier bundles (improves formatting time by ~50%) and also brings support for the latest Prettier 3.0.0 printing logic for JS. This upgrade is required in order to enable upcoming Flow features that add new syntax.Changelog: [Internal]
Reviewed By: SamChou19815
Differential Revision: D46748891