[Codegen 129]: add emitObjectProp in parser primitives #37872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tarunrajput
force-pushed
the
add-emitObjectProp
branch
from
643c0cf
to
deab6e8
Compare
tarunrajput
force-pushed
the
add-emitObjectProp
branch
from
deab6e8
to
949fe29
Compare
Base commit: b03c5af |
cipolleschi
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Thank you @tarunrajput for taking the time to work on this!
|
@rshest @cipolleschi , It seems the this PR was not merged correctly. So, I've opened a follow-up PR #37904 |
|
@tarunrajput I'm sorry for this. Thank you for the followup! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 15, 2023
Summary: This is a follow up PR to #37872 as it was not merged correctly. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal][Changed]: Add emitObjectProp in parser primitives Pull Request resolved: #37904 Test Plan: `yarn test react-native-codegen` Reviewed By: cipolleschi Differential Revision: D46753690 Pulled By: rshest fbshipit-source-id: a1d0a727222066f3721f62427a51ee0317e06f13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Part of #34872
Changelog:
[Internal][Changed]: Add emitObjectProp in parser primitives
Test Plan:
yarn test react-native-codegen