Add -Wno-error=cpp on App's default Cmake file #37516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46071400 |
Base commit: e93bc9b |
Summary: Pull Request resolved: facebook#37516 This will fail build failures from apps which are using libraries which imports ``` #include <react/renderer/graphics/conversions.h> ``` That's just a warning but our usage of `-Wall -Werror` is causing this to fail user builds. More context on this issue here: reactwg/react-native-releases#54 (comment) We can revert this `-Wno-error` once we're on 0.73 as that specific #warning will be entirely removed from the codebase. Changelog: [Internal] [Changed] - Add -Wno-error=cpp on App's default Cmake file Reviewed By: dmytrorykun Differential Revision: D46071400 fbshipit-source-id: f9a2341b72f755836bc171ec01d5ea7d930d5b42
cortinico
force-pushed
the
export-D46071400
branch
from
72d5b7c
to
cdbbf93
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46071400 |
|
This pull request has been merged in c396bc7. |
kelset
pushed a commit
that referenced
this pull request
May 25, 2023
Summary: Pull Request resolved: #37516 This will fail build failures from apps which are using libraries which imports ``` #include <react/renderer/graphics/conversions.h> ``` That's just a warning but our usage of `-Wall -Werror` is causing this to fail user builds. More context on this issue here: reactwg/react-native-releases#54 (comment) We can revert this `-Wno-error` once we're on 0.73 as that specific #warning will be entirely removed from the codebase. Changelog: [Internal] [Changed] - Add -Wno-error=cpp on App's default Cmake file Reviewed By: dmytrorykun Differential Revision: D46071400 fbshipit-source-id: 4937fb1255df3f2765f645dfd59f5c58526dee42
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This will fail build failures from apps which are using libraries which imports
That's just a warning but our usage of
-Wall -Werroris causing this to fail user builds.More context on this issue here:
reactwg/react-native-releases#54 (comment)
We can revert this
-Wno-erroronce we're on 0.73 as that specific #warning will be entirelyremoved from the codebase.
Changelog:
[Internal] [Changed] - Add -Wno-error=cpp on App's default Cmake file
Differential Revision: D46071400