Better TypeScript support for package.json exports field #37377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45769740 |
Base commit: 61335a1 |
|
This pull request was exported from Phabricator. Differential Revision: D45769740 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
) Summary: Pull Request resolved: facebook#37377 For 0.72 I enabled `moduleResolution: "nodenext"` which allows some package exports support, but this is imperfect. E.g. RN will typecheck against the `node` condition and there are some more restrictions than we need. D45720238 bumped TypeScript to 5.0 for RN 0.73, along with D45721088 which brought the tsconfig inline. This lets us switch to the new [`moduleResolution: "bundler"`](https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#moduleresolution-bundler) and instructs `tsc` to follow the `react-native` export condition. See even more context at: microsoft/TypeScript#51669 Changelog: [General][Added] - Better TypeScript support for package.json exports field Differential Revision: D45769740 fbshipit-source-id: 1e2ecbb0226c11b5ee556276cb742d361eddaeaf
NickGerleman
force-pushed
the
export-D45769740
branch
from
4897991 to
b29efb8
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
) Summary: Pull Request resolved: facebook#37377 For 0.72 I enabled `moduleResolution: "nodenext"` which allows some package exports support, but this is imperfect. E.g. RN will typecheck against the `node` condition and there are some more restrictions than we need. D45720238 bumped TypeScript to 5.0 for RN 0.73, along with D45721088 which brought the tsconfig inline. This lets us switch to the new [`moduleResolution: "bundler"`](https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#moduleresolution-bundler) and instructs `tsc` to follow the `react-native` export condition. See even more context at: microsoft/TypeScript#51669 Changelog: [General][Added] - Better TypeScript support for package.json exports field Differential Revision: D45769740 fbshipit-source-id: 0a016203e798bf655fb452a84f529e01abeaeb5c
NickGerleman
force-pushed
the
export-D45769740
branch
from
b29efb8 to
0de3cd9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45769740 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45769740 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 13, 2023
) Summary: Pull Request resolved: facebook#37377 For 0.72 I enabled `moduleResolution: "nodenext"` which allows some package exports support, but this is imperfect. E.g. RN will typecheck against the `node` condition and there are some more restrictions than we need. D45720238 bumped TypeScript to 5.0 for RN 0.73, along with D45721088 which brought the tsconfig inline. This lets us switch to the new [`moduleResolution: "bundler"`](https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#moduleresolution-bundler) and instructs `tsc` to follow the `react-native` export condition. See even more context at: microsoft/TypeScript#51669 Changelog: [General][Added] - Better TypeScript support for package.json exports field Reviewed By: christophpurrer Differential Revision: D45769740 fbshipit-source-id: 7bfad1f28f1e61f0a4cf3433f912b6eb06db864f
NickGerleman
force-pushed
the
export-D45769740
branch
from
0de3cd9 to
eee80c6
Compare
) Summary: Pull Request resolved: facebook#37377 For 0.72 I enabled `moduleResolution: "nodenext"` which allows some package exports support, but this is imperfect. E.g. RN will typecheck against the `node` condition and there are some more restrictions than we need. D45720238 bumped TypeScript to 5.0 for RN 0.73, along with D45721088 which brought the tsconfig inline. This lets us switch to the new [`moduleResolution: "bundler"`](https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#moduleresolution-bundler) and instructs `tsc` to follow the `react-native` export condition. See even more context at: microsoft/TypeScript#51669 Changelog: [General][Added] - Better TypeScript support for package.json exports field Reviewed By: christophpurrer Differential Revision: D45769740 fbshipit-source-id: ff8a7fd5e0de7ed2c391bb080bda33425b27fbb3
NickGerleman
force-pushed
the
export-D45769740
branch
from
eee80c6 to
86be8b6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45769740 |
|
This pull request has been merged in 1b0e8b1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For 0.72 I enabled
moduleResolution: "nodenext"which allows some package exports support, but this is imperfect. E.g. RN will typecheck against thenodecondition and there are some more restrictions than we need.D45720238 bumped TypeScript to 5.0 for RN 0.73, along with D45721088 which brought the tsconfig inline. This lets us switch to the new
moduleResolution: "bundler"and instructstscto follow thereact-nativeexport condition.See even more context at: microsoft/TypeScript#51669
Changelog:
[General][Added] - Better TypeScript support for package.json exports field
Differential Revision: D45769740