do not expose logger from RCTHost #37235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45513780 |
Summary: Pull Request resolved: facebook#37235 Changelog: [Internal] we shouldn't expose the logger, only need to expose the logging information Reviewed By: javache Differential Revision: D45513780 fbshipit-source-id: e1b562b18935fecb2059c5b8ea50ef5aec97f268
|
This pull request was exported from Phabricator. Differential Revision: D45513780 |
Base commit: 71fbb0c |
|
This pull request has been merged in b07c812. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#37235 Changelog: [Internal] we shouldn't expose the logger, only need to expose the logging information Reviewed By: javache Differential Revision: D45513780 fbshipit-source-id: b82496ebcbf87d7f88d6c7e1afea655d4177a0d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
we shouldn't expose the logger, only need to expose the logging information
Reviewed By: javache
Differential Revision: D45513780