Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN: Remove @reactions/component Dependency #37098

Closed
wants to merge 1 commit into from

Conversation

yungsters
Copy link
Contributor

Summary:
Removes reactions/component as a dependency.

As far as I can see, it is unused by react-native.

Changelog:
[Internal]

Differential Revision: D45304937

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Apr 26, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45304937

@github-actions
Copy link

github-actions bot commented Apr 26, 2023

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against b6d1076

yungsters added a commit to yungsters/react-native that referenced this pull request Apr 26, 2023
Summary:
Pull Request resolved: facebook#37098

Removes `reactions/component` as a dependency.

As far as I can see, it is unused by `react-native`.

Changelog:
[Internal]

Differential Revision: D45304937

fbshipit-source-id: 91e0ebf511ae869b9794d7eb915a71935b5d2c75
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45304937

@analysis-bot
Copy link

analysis-bot commented Apr 26, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,625,130 +0
android hermes armeabi-v7a 7,937,983 +0
android hermes x86 9,112,076 +0
android hermes x86_64 8,966,887 +0
android jsc arm64-v8a 9,189,170 +0
android jsc armeabi-v7a 8,379,482 +0
android jsc x86 9,247,475 +0
android jsc x86_64 9,505,920 +0

Base commit: 2cda4f7
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45304937

yungsters added a commit to yungsters/react-native that referenced this pull request Apr 26, 2023
Summary:
Pull Request resolved: facebook#37098

Removes `reactions/component` as a dependency.

As far as I can see, it is unused by `react-native`.

Changelog:
[Internal]

Differential Revision: D45304937

fbshipit-source-id: c02780332fa9073588ec05f55dfdbc786926ea03
Summary:
Pull Request resolved: facebook#37098

Removes `reactions/component` as a dependency.

As far as I can see, it is unused by `react-native`.

Changelog:
[Internal]

Reviewed By: GijsWeterings

Differential Revision: D45304937

fbshipit-source-id: 3c1b96f5711d80e7bbaf15bda51aa4ae47e86ec9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45304937

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f92d438.

jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#37098

Removes `reactions/component` as a dependency.

As far as I can see, it is unused by `react-native`.

Changelog:
[Internal]

Reviewed By: GijsWeterings

Differential Revision: D45304937

fbshipit-source-id: de90dce8049af2a7abe7c9cb0222fb4e3b0eb866
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#37098

Removes `reactions/component` as a dependency.

As far as I can see, it is unused by `react-native`.

Changelog:
[Internal]

Reviewed By: GijsWeterings

Differential Revision: D45304937

fbshipit-source-id: de90dce8049af2a7abe7c9cb0222fb4e3b0eb866
@yungsters yungsters deleted the export-D45304937 branch July 11, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants