Comment out unreferenced formal parameter #36853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: a6690bf |
|
C++ 17 added "[[maybe_unused]]" which I think is now the preferred way to do this. https://en.cppreference.com/w/cpp/language/attributes/maybe_unused |
|
@NickGerleman switched to use maybe_unused! |
|
@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Recent windows integration brought in a change where a unreferenced formal parameter was introduced in TurboModule.h. Windows treats with warning as an error, this change comments out the formal parameter name to get rid of the error/warning. ## Changelog: [GENERAL] [FIXED] - Comment out unreferenced formal parameter Pull Request resolved: facebook#36853 Test Plan: Passed Windows testcases Reviewed By: javache Differential Revision: D45007332 Pulled By: philIip fbshipit-source-id: 2e8128549d628a8be6bcd76c1fa473d0bc27649b
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Recent windows integration brought in a change where a unreferenced formal parameter was introduced in TurboModule.h. Windows treats with warning as an error, this change comments out the formal parameter name to get rid of the error/warning. ## Changelog: [GENERAL] [FIXED] - Comment out unreferenced formal parameter Pull Request resolved: facebook#36853 Test Plan: Passed Windows testcases Reviewed By: javache Differential Revision: D45007332 Pulled By: philIip fbshipit-source-id: 2e8128549d628a8be6bcd76c1fa473d0bc27649b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Recent windows integration brought in a change where a unreferenced formal parameter was introduced in TurboModule.h. Windows treats with warning as an error, this change comments out the formal parameter name to get rid of the error/warning.
Changelog:
[GENERAL] [FIXED] - Comment out unreferenced formal parameter
Test Plan:
Passed Windows testcases