Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fabric Interop constants example #36417

Closed
wants to merge 2 commits into from

Conversation

cipolleschi
Copy link
Contributor

Summary:
This changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper.

Changelog:

[iOS][Added] - Add example in the Interop Layer to use constants

Reviewed By: cortinico

Differential Revision: D43911916

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 9, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43911916

@react-native-bot react-native-bot added Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Mar 9, 2023
@analysis-bot
Copy link

analysis-bot commented Mar 9, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,516,921 +976
android hermes armeabi-v7a 7,832,583 +868
android hermes x86 8,997,353 +1,207
android hermes x86_64 8,852,549 +985
android jsc arm64-v8a 9,140,991 +310
android jsc armeabi-v7a 8,332,489 +314
android jsc x86 9,195,843 +320
android jsc x86_64 9,453,891 +314

Base commit: e26092a
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43911916

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Mar 9, 2023
Summary:
Pull Request resolved: facebook#36417

This changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper.

## Changelog:
[iOS][Added] - Add example in the Interop Layer to use constants

Reviewed By: cortinico

Differential Revision: D43911916

fbshipit-source-id: 2fda0e2861de20ca64a2845f100b57f2e170027a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43911916

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Mar 9, 2023
Summary:
Pull Request resolved: facebook#36417

This changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper.

## Changelog:
[iOS][Added] - Add example in the Interop Layer to use constants

Reviewed By: cortinico

Differential Revision: D43911916

fbshipit-source-id: 463d7c46b75ae1ead68196974e2e280060714f63
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43911916

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Mar 9, 2023
Summary:
Pull Request resolved: facebook#36417

This changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper.

## Changelog:
[iOS][Added] - Add example in the Interop Layer to use constants

Reviewed By: cortinico

Differential Revision: D43911916

fbshipit-source-id: 585669a3c997fc0f60a71789bafa7223ebff5c1c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43911916

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Mar 9, 2023
Summary:
Pull Request resolved: facebook#36417

This changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper.

## Changelog:
[iOS][Added] - Add example in the Interop Layer to use constants

Reviewed By: cortinico

Differential Revision: D43911916

fbshipit-source-id: c41863e0116fc3c0cf6a42c4df329733c05c5a34
Riccardo Cipolleschi and others added 2 commits March 10, 2023 02:36
Summary:
This changes adds an example to RNTester to verify that the Interop Layer can process bubbling events in Fabric as it used to do in Paper.

## Changelog:
[iOS][Added] - Add example in the Interop Layer to use events

Differential Revision: https://internalfb.com/D43911390

fbshipit-source-id: 4c168d39602f580268cc22b8e90a5f60699cdaad
Summary:
Pull Request resolved: facebook#36417

This changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper.

## Changelog:
[iOS][Added] - Add example in the Interop Layer to use constants

Reviewed By: cortinico

Differential Revision: D43911916

fbshipit-source-id: 1dd2cbed91233a6ef09b8511791c6a31669abdcb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43911916

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a5866ca.

cortinico added a commit to cortinico/react-native that referenced this pull request Mar 29, 2023
Summary:
Similar to facebook#36417, this changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper for Android.

Changelog:
[Android] [Added] - Add Fabric Interop constants example

Differential Revision: D44466391

fbshipit-source-id: 933a623d49a4405278a30cc7588d612945a3a910
cortinico added a commit to cortinico/react-native that referenced this pull request Mar 29, 2023
Summary:
Similar to facebook#36417, this changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper for Android.

Changelog:
[Android] [Added] - Add Fabric Interop constants example

Reviewed By: cipolleschi

Differential Revision: D44466391

fbshipit-source-id: f4af4a2509fb555d34343b794ffc5d3367840b09
cortinico added a commit to cortinico/react-native that referenced this pull request Mar 29, 2023
Summary:
Pull Request resolved: facebook#36693

Similar to facebook#36417, this changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper for Android.

Changelog:
[Android] [Added] - Add Fabric Interop constants example

Reviewed By: cipolleschi

Differential Revision: D44466391

fbshipit-source-id: 9d19e659ac7210abc47410cf9a705544f537e877
cortinico added a commit to cortinico/react-native that referenced this pull request Mar 29, 2023
Summary:
Similar to facebook#36417, this changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper for Android.

Changelog:
[Android] [Added] - Add Fabric Interop constants example

Differential Revision: D44466391

fbshipit-source-id: 59012abda0701c1413658c1b48adace862089b56
facebook-github-bot pushed a commit that referenced this pull request Mar 29, 2023
Summary:
Pull Request resolved: #36693

Similar to #36417, this changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper for Android.

Changelog:
[Android] [Added] - Add Fabric Interop constants example

Reviewed By: cipolleschi

Differential Revision: D44466391

fbshipit-source-id: 74e654319b93e60b415297dcdddc98eb100913df
cipolleschi pushed a commit that referenced this pull request Mar 31, 2023
Summary:
Pull Request resolved: #36693

Similar to #36417, this changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper for Android.

Changelog:
[Android] [Added] - Add Fabric Interop constants example

Reviewed By: cipolleschi

Differential Revision: D44466391

fbshipit-source-id: 74e654319b93e60b415297dcdddc98eb100913df
jeongshin pushed a commit to jeongshin/react-native that referenced this pull request May 7, 2023
Summary:
Pull Request resolved: facebook#36693

Similar to facebook#36417, this changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper for Android.

Changelog:
[Android] [Added] - Add Fabric Interop constants example

Reviewed By: cipolleschi

Differential Revision: D44466391

fbshipit-source-id: 74e654319b93e60b415297dcdddc98eb100913df
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36417

This changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper.

## Changelog:
[iOS][Added] - Add example in the Interop Layer to use constants

Reviewed By: cortinico

Differential Revision: D43911916

fbshipit-source-id: 1d4b630d45d21904c53d85b97607ebb7fb8a62fc
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36693

Similar to facebook#36417, this changes adds an example to RNTester to verify that the Interop Layer can process constants in Fabric as it used to do in Paper for Android.

Changelog:
[Android] [Added] - Add Fabric Interop constants example

Reviewed By: cipolleschi

Differential Revision: D44466391

fbshipit-source-id: 74e654319b93e60b415297dcdddc98eb100913df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: iOS iOS applications. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants