update asdf-vm setup to use $ASDF_DIR to work if user defined custom directory
#36043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 5647d79 |
cipolleschi
approved these changes
Feb 3, 2023
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in f6a4e4f. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…tom directory (facebook#36043) Summary: Update setup of sourcing `asdf-vm` in `find-node-for-xcode.sh` in case of user has custom defined of `$ASDF_DIR` by default `$ASDF_DIR` point to `$HOME/.asdf`, but if user has custom directory (like XDG convention) this script wont work without this change. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [CHANGED] - Find node binary when using asdf as the node version manager with custom `$ASDF_DIR` Pull Request resolved: facebook#36043 Test Plan: use a defualt/custom `$ASDF_DIR` while using `asdf-vm` as node version manager then make iOS build. Reviewed By: cortinico Differential Revision: D42990407 Pulled By: cipolleschi fbshipit-source-id: 1fe3fdc786bddf741ff422e7bec55a6c9cc8ed83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update setup of sourcing
asdf-vminfind-node-for-xcode.shin case of user has custom defined of$ASDF_DIRby default
$ASDF_DIRpoint to$HOME/.asdf, but if user has custom directory (like XDG convention) this script wont work without this change.Changelog
[GENERAL] [CHANGED] - Find node binary when using asdf as the node version manager with custom
$ASDF_DIRTest Plan
use a defualt/custom
$ASDF_DIRwhile usingasdf-vmas node version manager then make iOS build.