react-native: Use number literals in TypeScript types for FileReader and XMLHttpRequest states
#36000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 8d5f880 |
|
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
7 tasks
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…` and `XMLHttpRequest` states (facebook#36000) Summary: Mostly to improve compat in codebases where `lib.dom.d.ts` is loaded alongside RN. TS 5.0 updates to `lib.dom.d.ts` added number literals for these states as well so the abstract `number` type from RN was no longer compatible. Forward-port of DefinitelyTyped/DefinitelyTyped#64144 Underlying flow types: - https://github.com/facebook/react-native/blob/v0.71.1/Libraries/Blob/FileReader.js#L33-L35 - https://github.com/facebook/react-native/blob/v0.71.1/Libraries/Network/XMLHttpRequest.js#L54-L58 ## Changelog [GENERAL] [CHANGED] - Use number literals in TypeScript types for `FileReader` and `XMLHttpRequest` states Pull Request resolved: facebook#36000 Test Plan: - [x] DefinitelyTyped/DefinitelyTyped#64144 green Reviewed By: christophpurrer Differential Revision: D42849886 Pulled By: jacdebug fbshipit-source-id: c3cf2ac4f5f53ab889a9190583486da4627d3dcc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mostly to improve compat in codebases where
lib.dom.d.tsis loaded alongside RN. TS 5.0 updates tolib.dom.d.tsadded number literals for these states as well so the abstractnumbertype from RN was no longer compatible.Forward-port of DefinitelyTyped/DefinitelyTyped#64144
Underlying flow types:
Changelog
[GENERAL] [CHANGED] - Use number literals in TypeScript types for
FileReaderandXMLHttpRequeststatesTest Plan
FileReaderandXMLHttpRequeststates DefinitelyTyped/DefinitelyTyped#64144 green