Fix whitespace and newline at EOF #35939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
|
The changes look like they are in random places all over the code. @cortinico , it probably could have been a land-blocking thing whenever it was committed, to begin with?.. |
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: c195487 |
@rshest Agree. This is something that arcanist should have catched though. We don't have pre-commit hooks in OSS for new-lines or whitespace sadly. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Just a couple of minor fixes in the `template/` folder: - Remove a trailing space in `rn_edit_text_material.xml` (this was the _only_ trailing space present in a newly generated RN project), which results in the check against the empty tree object failing: ``` $ git diff --check 4b825dc -- template/ template/android/app/src/main/res/drawable/rn_edit_text_material.xml:23: trailing whitespace. + <!-- ``` - Add missing newline at end of file in `.watchmanconfig` and `app.json` - Both are text files, and each line (including the last) is expected to end with a newline character (flagged by Git, and also visible as a warning on GitHub): <img width="369" alt="image" src="https://user-images.githubusercontent.com/743291/214195867-81c8e622-2130-44d4-bdaf-588e3510c109.png"> ## Changelog [GENERAL] [FIXED] - Fix whitespace and newline at EOF in template Pull Request resolved: facebook#35939 Reviewed By: christophpurrer Differential Revision: D42698256 Pulled By: rshest fbshipit-source-id: 765fd41d4f501aec578755c754ea0ecb290ae6ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple of minor fixes in the
template/folder:rn_edit_text_material.xml(this was the only trailing space present in a newly generated RN project), which results in the check against the empty tree object failing:.watchmanconfigandapp.json- Both are text files, and each line (including the last) is expected to end with a newline character (flagged by Git, and also visible as a warning on GitHub):Changelog
[GENERAL] [FIXED] - Fix whitespace and newline at EOF in template