Null Exception Handling | Input Validation - RCTAlertController - RCTDevLoadingView

[admirsaheta]

Summary

Enhancing native iOS modules and preventing crashes inside the RCTAlertController

Changelog

[iOS][Fixed] - Handle properly a nil keyWindows in the AlertController

Test Plan

[facebook-github-bot]

Hi @admirsaheta!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,466,919	+197
android	hermes	armeabi-v7a	7,786,248	+275
android	hermes	x86	8,941,163	+500
android	hermes	x86_64	8,799,075	+451
android	jsc	arm64-v8a	9,652,809	+0
android	jsc	armeabi-v7a	8,386,008	+0
android	jsc	x86	9,716,196	+0
android	jsc	x86_64	10,193,922	+0

Base commit: 9f78517
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 9f78517
Branch: main

[pull-bot]

PR build artifact for 79f32b4 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[pull-bot]

PR build artifact for 79f32b4 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[admirsaheta]

Input validators have been added to make sure nothing breaks

[pull-bot]

PR build artifact for be8c03e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[pull-bot]

PR build artifact for be8c03e is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[pull-bot]

PR build artifact for a7ea796 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[pull-bot]

PR build artifact for a7ea796 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[cipolleschi]

Hi @admirsaheta, thank you for taking care of this.
The PR looks good. Can I ask you to update the changelog in the summary, please? 🙏🏻

The proper format should be something like:

## Changelog:
[iOS][Fixed] - Handle properly a `nil` `keyWindows` in the AlertController

The problem, currently, is that your changelog is wrapped in <!-- --> and it is considered by GitHub as a comment, thus it is not visible.

Thank you so much!

[facebook-github-bot]

@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@ryancat merged this pull request in 79e603c.