Refactor codegen: Dispatch props and events from a central place. #34975
+84
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Closed
Base commit: e4b5d3e |
Base commit: e4b5d3e |
cipolleschi
requested changes
Oct 14, 2022
There was a problem hiding this comment.
Hi, thank for taking this.
I left a couple of comments in the PR.
Plus, are you going to make the same changes for Flow?
I think we should strive to keep the two languages aligned, so it will be easier to create a common denominator to reduce the code duplication (as we are doing for the modules)
packages/react-native-codegen/src/parsers/typescript/components/events.js
Outdated
Show resolved
Hide resolved
packages/react-native-codegen/src/parsers/typescript/components/props.js
Outdated
Show resolved
Hide resolved
cipolleschi
reviewed
Oct 17, 2022
packages/react-native-codegen/src/parsers/typescript/components/extends.js
Outdated
Show resolved
Hide resolved
packages/react-native-codegen/src/parsers/typescript/components/extends.js
Outdated
Show resolved
Hide resolved
packages/react-native-codegen/src/parsers/typescript/components/extends.js
Outdated
Show resolved
Hide resolved
ZihanChen-MSFT
force-pushed
the
ts-rncodegen12
branch
from
19f0700
to
b448c6e
Compare
ZihanChen-MSFT
force-pushed
the
ts-rncodegen12
branch
from
b448c6e
to
f33ed6f
Compare
cipolleschi
approved these changes
Oct 19, 2022
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Oct 19, 2022
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @ZihanChen-MSFT in affcfa7. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…cebook#34975) Summary: Refer to `In component, props and events pick properties from the component interface by themselves independently, I would like to reverse the direction, to have a function dispatching properties to props and events, to reduce duplicated code. ` in facebook#34872 ## Changelog [General] [Changed] - Refactor codegen: Dispatch props and events from a central place. Pull Request resolved: facebook#34975 Test Plan: `yarn jest react-native-codegen` passed Reviewed By: cortinico Differential Revision: D40507917 Pulled By: cipolleschi fbshipit-source-id: 71988877008ae11a01affd31b34bb3a3b88f96be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refer to
In component, props and events pick properties from the component interface by themselves independently, I would like to reverse the direction, to have a function dispatching properties to props and events, to reduce duplicated code.in #34872Changelog
[General] [Changed] - Refactor codegen: Dispatch props and events from a central place.
Test Plan
yarn jest react-native-codegenpassed