[Android][Improvement] Improve support for non debug/release variants

[sidferreira]

The current change allows projects to use different variants, staging in our case, properly.

Summary

In one of our projects, we have a third variant which is Staging. Without this change, our staging builds will crash with #33120

Changelog

[Android] [Added] - Add conditionals for releases that are not named debug/release

Test Plan

[danilobuerger]

Does this also fix #34686?

[sidferreira]

@danilobuerger it looks like, but I wasn't familiar with that issue (I basically fixed it locally and suggested a PR)

[cortinico]

Thanks for your PR @sidferreira

I don't think we're going to merge this. The reason is that the deleteDebugFilesForVariant is already customizable. Users can specify a config.deleteDebugFilesForVariant

Your change will unnecessarily extend the API surface. Moreover it relies on Groovy dynamic property resolution, which is well supported in Kotlin. If we were to include this, we would have to extend also the react-native-gradle-plugin. As mentioned, I don't think we're going to do so.

I'm closing this for the aformentioned reasons.
Happy to discuss further if you wish 👍

[cortinico]

Does this also fix #34686?

@danilobuerger Nope it does not. The changes are related but there is no fix needed for #34686

[sidferreira]

@cortinico make sense. The only reason I dis it is cause other similar functions have the same pattern, it sounded like the best approach.

I'm just not sure there's a guide on how to add extra variants support...

[cortinico]

I'm just not sure there's a guide on how to add extra variants support...

Nope there is no guide sadly. We're moving to use the React Native Gradle Plugin which will have a better variant support instead of doing string matching. We'll provide docs for it once it lands 👍

[sidferreira]

@cortinico thanks for your work and your answers