Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image cache did not take into account request cache policy #34556

Closed
wants to merge 1 commit into from

Conversation

matpaul
Copy link
Contributor

@matpaul matpaul commented Sep 1, 2022

Summary

Image Component cache = 'reload' prop not worked correct because inner Image cache did not take into account request cache (cache property convert in RCTConvert into request.cachePolicy).

Fixes #9195

Changelog

[IOS] [Fixed] - Image Component will not update correctly when passing in new url

Test Plan

Reproduce code: https://snack.expo.dev/@rundbom/image-should-update

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 1, 2022
@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Sep 1, 2022
@facebook-github-bot
Copy link
Contributor

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,635,165 +0
android hermes armeabi-v7a 7,047,162 +0
android hermes x86 7,937,127 +0
android hermes x86_64 7,909,156 +0
android jsc arm64-v8a 9,512,123 +0
android jsc armeabi-v7a 8,287,415 +0
android jsc x86 9,451,652 +0
android jsc x86_64 10,042,904 +0

Base commit: 3db19b4
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 3db19b4
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @matpaul in 5c211f2.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Component will not update correctly when passing in new url
4 participants