Introduce findPackageJsonFile to address issue with GenerateCodegenArtifactsTaskTest #34321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @cortinico in 6f76122. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Aug 2, 2022
…tifactsTaskTest (#34321) Summary: While doing some testing with cipolleschi on React Native 0.70.0 we realized that custom Java Package is not properly propagated when invoking codegen for external libraries. This PR fixes it. ## Changelog [Internal] - Introduce findPackageJsonFile to address issue with GenerateCodegenArtifactsTaskTest Pull Request resolved: #34321 Test Plan: Added JUnit tests + Tested locally with cipolleschi Reviewed By: cipolleschi Differential Revision: D38314770 Pulled By: cortinico fbshipit-source-id: ec2de1ba59ffc8fb0644f422521ced642b38d2c7
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…tifactsTaskTest (facebook#34321) Summary: While doing some testing with cipolleschi on React Native 0.70.0 we realized that custom Java Package is not properly propagated when invoking codegen for external libraries. This PR fixes it. ## Changelog [Internal] - Introduce findPackageJsonFile to address issue with GenerateCodegenArtifactsTaskTest Pull Request resolved: facebook#34321 Test Plan: Added JUnit tests + Tested locally with cipolleschi Reviewed By: cipolleschi Differential Revision: D38314770 Pulled By: cortinico fbshipit-source-id: ec2de1ba59ffc8fb0644f422521ced642b38d2c7
roryabraham
pushed a commit
to Expensify/react-native
that referenced
this pull request
Aug 17, 2022
…tifactsTaskTest (facebook#34321) Summary: While doing some testing with cipolleschi on React Native 0.70.0 we realized that custom Java Package is not properly propagated when invoking codegen for external libraries. This PR fixes it. ## Changelog [Internal] - Introduce findPackageJsonFile to address issue with GenerateCodegenArtifactsTaskTest Pull Request resolved: facebook#34321 Test Plan: Added JUnit tests + Tested locally with cipolleschi Reviewed By: cipolleschi Differential Revision: D38314770 Pulled By: cortinico fbshipit-source-id: ec2de1ba59ffc8fb0644f422521ced642b38d2c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While doing some testing with @cipolleschi on React Native 0.70.0 we realized that custom Java Package is not properly propagated when invoking codegen for external libraries.
This PR fixes it.
Changelog
[Internal] - Introduce findPackageJsonFile to address issue with GenerateCodegenArtifactsTaskTest
Test Plan
Added JUnit tests + Tested locally with @cipolleschi