Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade RN CLI to v8 alpha.5 #33755

Closed
wants to merge 1 commit into from
Closed

Upgrade RN CLI to v8 alpha.5 #33755

wants to merge 1 commit into from

Conversation

thymikee
Copy link
Contributor

@thymikee thymikee commented May 4, 2022 •
edited
Loading

Summary

Upgrades the React Native CLI to v8 alpha.4. Includes Metro bump to 0.70. cc @fortmarek @kelset @cortinico

Changelog

[General] [Changed] - Upgrade RN CLI to v8 alpha.4

Test Plan

CI

@thymikee thymikee requested a review from hramos as a code owner May 4, 2022 10:54
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner labels May 4, 2022
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

fortmarek
fortmarek approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for sending this in @thymikee!

@pull-bot
Copy link

pull-bot commented May 4, 2022

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 1f111bd

@geraintwhite geraintwhite mentioned this pull request May 4, 2022
Closed
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,774,039 -2,535
android hermes armeabi-v7a 7,179,302 -2,536
android hermes x86 8,082,596 -2,744
android hermes x86_64 8,063,125 -2,492
android jsc arm64-v8a 9,646,107 -3,934
android jsc armeabi-v7a 8,420,126 -3,926
android jsc x86 9,595,512 -3,932
android jsc x86_64 10,192,921 -3,931

Base commit: e7d9e4d
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: e7d9e4d
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @thymikee in 1e0226f.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 6, 2022
@cortinico
Copy link
Contributor

@fortmarek 1e0226f this should be picked on .69.0-rc1 👍

fortmarek pushed a commit that referenced this pull request May 11, 2022
@thymikee @fortmarek
Upgrade RN CLI to v8 alpha.5 (#33755)
a1388c8 
Summary:
Upgrades the React Native CLI to v8 alpha.5. Includes Metro bump to 0.70.2 cc fortmarek kelset cortinico

## Changelog

[General] [Changed] - Upgrade RN CLI to v8 alpha.5

Pull Request resolved: #33755

Test Plan: CI

Reviewed By: motiz88, cipolleschi

Differential Revision: D36128899

Pulled By: cortinico

fbshipit-source-id: b9ce0b4f9fef356141a79be9ccdcabd841d6d1ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortmarek fortmarek fortmarek approved these changes

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thymikee @facebook-github-bot @pull-bot @analysis-bot @react-native-bot @cortinico @fortmarek