-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: upgrading OkHttp from 4.9.1 to 4.9.2 to fix CVE-2021-0341 #32968
Conversation
Hi @owjsub! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Base commit: 8b5a5d4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. Can you sign the CLA otherwise we can't merge this PR as it is?
Base commit: 8b5a5d4 |
Will sign the CLA shortly |
CLA signed |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This is falling internally due to reasons that are unrelated to your changes. It will take a bit longer than usual to be merged, sorry for the inconvenience. |
This pull request was successfully merged by @owjsub in d6db5c5. When will my fix make it into a release? | Upcoming Releases |
…32968) Summary: Security vulnerability CVE-2021-0341 is present in okhttp 4.9.1. Upgrading to 4.9.2 will resolve the issue. http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2021-0341 ## Changelog [Android] [Security] - Upgraded okhttp to 4.9.2 to fix CVE-2021-0341 Pull Request resolved: #32968 Test Plan: Upgrading okhttp 4.9.1 to 4.9.2 should be backwards compatible per https://github.com/square/okhttp/blob/master/CHANGELOG.md#version-492. Should be safe to merge if CircleCI tests pass. Reviewed By: ShikaSD Differential Revision: D33788131 Pulled By: cortinico fbshipit-source-id: e9593a42a8e40a903ee6f529d94c82adcf5d0977 # Conflicts: # ReactAndroid/gradle.properties
Summary
Security vulnerability CVE-2021-0341 is present in okhttp 4.9.1. Upgrading to 4.9.2 will resolve the issue.
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2021-0341
Changelog
[Android] [Security] - Upgraded okhttp to 4.9.2 to fix CVE-2021-0341
Test Plan
Upgrading okhttp 4.9.1 to 4.9.2 should be backwards compatible per https://github.com/square/okhttp/blob/master/CHANGELOG.md#version-492. Should be safe to merge if CircleCI tests pass.