Implement Runtime.getHeapUsage for hermes chrome inspector

[janicduplessis]

Summary

I was looking at the hermes chrome devtools integration and noticed requests to Runtime.getHeapUsage which was not implemented. When implemented it will show a summary of memory usage of the javascript instance in devtools.

Changelog

[General] [Added] - Implement Runtime.getHeapUsage for hermes chrome inspector

Test Plan

Before

After

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 6b42bcc
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,292,280	-150
android	hermes	armeabi-v7a	7,627,521	-144
android	hermes	x86	8,764,571	-149
android	hermes	x86_64	8,701,499	-145
android	jsc	arm64-v8a	9,679,496	-102
android	jsc	armeabi-v7a	8,671,414	-112
android	jsc	x86	9,637,281	-113
android	jsc	x86_64	10,231,803	-107

Base commit: 6b42bcc
Branch: main

[janicduplessis]

I realized most of the code is generated using tools/run_msggen. I was able to adapt the script to make it usable outside fb, except for the signedsource part. So someone will have to re-run the codegen in the fb repo. (cd ReactCommon/hermes/inspector/tools && ./run_msggen).

I also added support for including experimental commands to msggen since Runtime.getHeapUsage is considered experimental. I added a config with a list of experimental commands to include otherwise it will generate a lot more types that were previously ignored if not passing --ignore-experimental.

Updating the chrome devtools npm package caused some changes to the schema so there are a few unrelated new properties.

[facebook-github-bot]

@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @janicduplessis in 3568a72.

^{When will my fix make it into a release? | Upcoming Releases}

[ShikaSD]

Hey, @janicduplessis, seems like update of the devtools version made the "params" field required for the resume command, breaking some internal tooling. Would it be possible to either implement the same command without upgrading the version or update codegen to make sure params field is optional?
I am reverting it for now, as we have a cutoff for internal tooling release in a hour :)

[facebook-github-bot]

This pull request has been reverted by 2bc883e.

[janicduplessis]

Sadly the command does not exist when using the current devtools protocol version. I checked and it was added after the params object to resume, so there is also no version that exist where it would work.

Would it be hard to update the internal tool to pass params? Other option would be to make the codegen check if params exist, but would cause lots of changes to the codegen output.

[ShikaSD]

Would it be hard to update the internal tool to pass params?

It seems like we have quite a few tools that use this codegen as a source of truth, so probably it is better to modify codegen to check for optional param :)
Does input for the codegen specify whether the param is optional or not? I believe we can add this check to only apply when the parameter is not required, so it should be negligible here.

[janicduplessis]

Actually it might be possible to address with minimal changes by checking if all parameters are optional, then make the whole params object optional.

[janicduplessis]

Does input for the codegen specify whether the param is optional or not? I believe we can add this check to only apply when the parameter is not required, so it should be negligible here.

Yep https://github.com/ChromeDevTools/devtools-protocol/blob/master/json/js_protocol.json#L641