Added missing constructor to WritableNativeArray #32796
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WritableNativeMap
has two constructors:but
WritableNativeArray
has only one constructor:WritableNativeArray();
Without a second constructor, I am not able to create
WritableNativeArray
from the existing array. I added this second constructor because I need it forreact-native-reanimated
.Changelog
[Android] [Added] - Added missing constructor to WritableNativeArray
Test Plan
std::shared_ptr<jsi::Runtime> rt = facebook::hermes::makeHermesRuntime(); jsi::Value value; WritableNativeArray::newObjectCxxArgs(jsi::dynamicFromValue(*rt.get(), value));