Don't reconstruct app component on split-screen #32536
Conversation
|
Hi @Somena1! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Base commit: ebb26cf |
Base commit: ebb26cf |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
Shared with Meta
|
@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@yungsters merged this pull request in fc962c9. |
This fixes an issue where the app would restart on entering split screen, or on resizing the app's side of a split screen. Basically this line of the Android manifest is making an assurance to the system that the app is prepared to handle these changes; docs here: https://developer.android.com/guide/topics/manifest/activity-element#config When the system doesn't get that assurance, it just restarts the app from scratch to be sure. And empirically the app indeed does just fine when we add those assurances and then go ahead and switch to split-screen mode, or resize the app's portion of the split screen. That layer of things is basically all RN's job, so RN is handling this just fine -- we just haven't been letting the system know that we're ready to do so. Also got this fixed in the RN template app upstream: facebook/react-native#32536 facebook/react-native@fc962c9b6 [greg: expanded commit message] Fixes: zulip#5068
This fixes an issue where the app would restart on entering split screen, or on resizing the app's side of a split screen. Basically this line of the Android manifest is making an assurance to the system that the app is prepared to handle these changes; docs here: https://developer.android.com/guide/topics/manifest/activity-element#config When the system doesn't get that assurance, it just restarts the app from scratch to be sure. And empirically the app indeed does just fine when we add those assurances and then go ahead and switch to split-screen mode, or resize the app's portion of the split screen. That layer of things is basically all RN's job, so RN is handling this just fine -- we just haven't been letting the system know that we're ready to do so. Also got this fixed in the RN template app upstream: facebook/react-native#32536 facebook/react-native@fc962c9b6 [greg: expanded commit message] Fixes: zulip#5068
Summary
When switching between split screen or resizing the screen window on Android causes a restart by reconstructing the app components as described on this issue #25040
Changelog
[Android] [Fixed] - Don't reconstruct app components #25040
Test Plan
How to reproduce
Expected:
Result:
Same issue can be seen when resizing the split screen window