Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packager] Expose the projectRoots option #3246

Closed
wants to merge 1 commit into from

Conversation

ide
Copy link
Contributor

@ide ide commented Oct 6, 2015

This was already implemented -- just documenting it in the CLI.

Test Plan: packager.sh --projectRoot /my/project

@ide ide added the Packager label Oct 6, 2015
@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 6, 2015
This was already implemented -- just documenting it in the CLI.

Test Plan: `packager.sh --projectRoot /my/project`
@ide ide force-pushed the packager-project-root branch from 99b16d7 to 67d05bd Compare October 15, 2015 23:15
@facebook-github-bot
Copy link
Contributor

@ide updated the pull request.

@ide ide assigned martinbigio and unassigned amasad Oct 19, 2015
@ide
Copy link
Contributor Author

ide commented Oct 19, 2015

@martinbigio could you please have a look at this? (pretty small diff)

@martinbigio
Copy link
Contributor

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1622060418043501/int_phab to review.

@ide ide closed this in 93c56a0 Oct 20, 2015
MattFoley pushed a commit to skillz/react-native that referenced this pull request Nov 9, 2015
Summary: This was already implemented -- just documenting it in the CLI.
Closes facebook#3246

Reviewed By: svcscm

Differential Revision: D2560211

Pulled By: martinbigio

fb-gh-sync-id: c4e4d974db28d6251636ff38bfcb0afdf5148de7
Crash-- pushed a commit to Crash--/react-native that referenced this pull request Dec 24, 2015
Summary: This was already implemented -- just documenting it in the CLI.
Closes facebook#3246

Reviewed By: svcscm

Differential Revision: D2560211

Pulled By: martinbigio

fb-gh-sync-id: c4e4d974db28d6251636ff38bfcb0afdf5148de7
@ide ide deleted the packager-project-root branch March 11, 2016 08:47
cpojer pushed a commit to facebook/metro that referenced this pull request Jan 26, 2017
Summary: This was already implemented -- just documenting it in the CLI.
Closes facebook/react-native#3246

Reviewed By: svcscm

Differential Revision: D2560211

Pulled By: martinbigio

fb-gh-sync-id: c4e4d974db28d6251636ff38bfcb0afdf5148de7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants