iOS Ruby Updates #32456
Closed
iOS Ruby Updates #32456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubygem's bundle will only use config as described in: https://bundler.io/man/bundle-config.1.html#DESCRIPTION 1. Local config (<project_root>/.bundle/config or $BUNDLE_APP_CONFIG/config) 2. Environmental variables (ENV) 3. Global config (~/.bundle/config) While in the root directory it was using the facebook#1 (.bundle/config), in the template it wasn't since the folder is `_bundle` (underscore, not a leading dot). This commit makes sure the desired config is used, also takes care to sync both configuration files, copying the root to the template.
Also fix template/Gemfile.lock PLATFORM, it should be "ruby" and not specific to ARM64/BigSur. This was done by calling: ./scripts/update-ruby.sh
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
|
PR build artifact for 92c6172 is ready. |
Base commit: eccbf9b |
|
@charlesbdudley has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Base commit: 7b77cc6 |
|
@charlesbdudley merged this pull request in 1e6add1. |
lunaleaps
pushed a commit
that referenced
this pull request
Oct 22, 2021
Summary: Fix the `scripts/update-ruby.sh` so it always use the correct [bundle config](https://bundler.io/man/bundle-config.1.html#DESCRIPTION). In the current version it wasn't using the correct configuration inside the `template/` directory, resulting in incorrect platform for `template/Gemfile.lock`. While at that, update the gems to their latest version: - ethon 0.14.0 -> 0.15.0 - json 0.5.1 -> 0.6.0 - zeitwerk 2.4.2 -> 2.5.1 - bundler 2.2.28 -> 2.2.29 No changelog Pull Request resolved: #32456 Test Plan: Run `bump-oss-version.js` and see `template/Gemfile.lock` lists `ruby` as the `PLATFORM` (no diff in that line). - e18cf90#r58230816 Reviewed By: yungsters Differential Revision: D31841524 Pulled By: charlesbdudley fbshipit-source-id: 695c245fcb344c866afed45f747e04233e5c91e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
scripts/update-ruby.shso it always use the correct bundle config. In the current version it wasn't using the correct configuration inside thetemplate/directory, resulting in incorrect platform fortemplate/Gemfile.lock.While at that, update the gems to their latest version:
Changelog
No changelog
Test Plan
Run
bump-oss-version.jsand seetemplate/Gemfile.locklistsrubyas thePLATFORM(no diff in that line).References