Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing Android dangerous permissions #32445

Closed
wants to merge 1 commit into from
Closed

feat: add missing Android dangerous permissions #32445

wants to merge 1 commit into from

Conversation

iBotPeaches
Copy link
Contributor

Summary

This PR adds all missing dangerous permissions in Android. I recently updated these for Android 12 and found many more missing dating all the way back to API 26. After this PR, it will be in sync with ALL dangerous permissions as of the recently released Android 12.

https://developer.android.com/reference/android/Manifest.permission.html#ACCEPT_HANDOVER - 28
https://developer.android.com/reference/android/Manifest.permission.html#ACTIVITY_RECOGNITION - 29
https://developer.android.com/reference/android/Manifest.permission.html#ANSWER_PHONE_CALLS - 26
https://developer.android.com/reference/android/Manifest.permission.html#READ_PHONE_NUMBERS - 26
https://developer.android.com/reference/android/Manifest.permission.html#UWB_RANGING - 31

Changelog

[Android] [Changed] - Add ACCEPT_HANDOVER, ACTIVITY_RECOGNITION, ANSWER_PHONE_CALLS, READ_PHONE_NUMBERS & UWB_RANGING to PermissionsAndroid

Test Plan

PermissionsAndroid.ACCEPT_HANDOVER === 'android.permission.ACCEPT_HANDOVER'
PermissionsAndroid.ACTIVITY_RECOGNITION === 'android.permission.ACTIVITY_RECOGNITION'
PermissionsAndroid.ANSWER_PHONE_CALLS === 'android.permission.ANSWER_PHONE_CALLS'
PermissionsAndroid.READ_PHONE_NUMBERS === 'android.permission.READ_PHONE_NUMBERS'
PermissionsAndroid.UWB_RANGING === 'android.permission.UWB_RANGING'

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 20, 2021
@react-native-bot react-native-bot added the Platform: Android Android applications. label Oct 20, 2021
@facebook-github-bot
Copy link
Contributor

@sshic has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented Oct 20, 2021

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: c7d0c94
Branch: main

 - ACCEPT_HANDOVER (API 28)
 - ACTIVITY_RECOGNITION (API 29)
 - ANSWER_PHONE_CALLS (API 26)
 - READ_PHONE_NUMBERS (API 26)
 - UWB_RANGING (API 31)
@pull-bot
Copy link

PR build artifact for 84a6c8d is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,281,533 +11
android hermes armeabi-v7a 7,845,657 +5
android hermes x86 8,648,577 +6
android hermes x86_64 8,607,725 +5
android jsc arm64-v8a 9,798,130 +90
android jsc armeabi-v7a 8,759,077 +97
android jsc x86 9,747,048 +96
android jsc x86_64 10,347,906 +96

Base commit: c7d0c94
Branch: main

@facebook-github-bot
Copy link
Contributor

@sshic merged this pull request in 4b25a0a.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 22, 2021
@iBotPeaches iBotPeaches deleted the permission-sync branch October 22, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants