Export prepareBoost to an internal task #32424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lugin Summary: While working on the NDK AGP Apis, I realized the the `applyAppPlugin` is accessed too early inside the Gradle plugin. Specifically is accessed once the plugin is applied, and the extension is not configured afterwards. This means that the extension is always set the default values. I'm fixing it moving it inside the `project.afterEvaluate` that was already need to access the variant informations. Changelog: [Internal] [Changed] - Fix applyAppPlugin being accessed too early in the React App Gradle Plugin Differential Revision: D31652984 fbshipit-source-id: bef6617b645df26d67e34df7c93a3f5065637531
Summary: While working on the NDK AGP Api I realized that the `enableVmCleanup` function, that is supposed to cleanup the extra `.so` files from the final artifacts, is broken for apps with variants. Specifically say for a `liteDebug` app it tries to search for `.so` files inside: ``` intermediates/stripped_native_libs/lite/debug/out/lib ``` while the `.so` files are located inside: ``` intermediates/stripped_native_libs/liteDebug/out/lib ``` I've fixed changing the token of the path from `targetPath` to `variant.name` Changelog: [Android] [Fixed] - Fix enableVmCleanup not working for apps with product flavors Differential Revision: D31654704 fbshipit-source-id: 8d4254ed038f5b286c8eb6c99974abbcd2baa122
Summary: This diff refactors the `prepareGlog` task to a separate Gradle task in the `.internal` package. The reason for this change is that `prepareGlog` was defining a `doLast` action and would result in being invalidated whenever the `build.gradle` file would change. This means that the Glog headers/source files would have been extracted again, effectively invalidating the timestamps for the native build. Changelog: [Internal] [Changed] - Export prepareGlog to an internal task Differential Revision: D31661668 fbshipit-source-id: d65a021df6f633dd902ef1b5dde6cf3cd88b51e1
Summary: This diff refactors the `prepareLibevent` task to a separate Gradle task in the `.internal` package. The reason for this change is that `prepareLibevent` was defining a `doLast` action and would result in being invalidated whenever the `build.gradle` file would change. This means that the Libevent headers/source files would have been extracted again, effectively invalidating the timestamps for the native build. Changelog: [Internal] [Changed] - Export prepareLibevent to an internal task Differential Revision: D31661988 fbshipit-source-id: 0f3915dd61ddbf9facbc696a7de2243bf7a92c54
Summary: This diff refactors the `prepareBoost` task to a separate Gradle task in the `.internal` package. The reason for this change is that `prepareBoost` was defining a `doLast` action and would result in being invalidated whenever the `build.gradle` file would change. This means that the Boost headers/source files would have been extracted again, effectively invalidating the timestamps for the native build. Changelog: [Internal] [Changed] - Export prepareBoost to an internal task Reviewed By: ShikaSD Differential Revision: D31662120 fbshipit-source-id: 1af56d1e4405cb7da66b246498d30f1b364a9ca3
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D31662120 |
|
|
PR build artifact for 351f6ad is ready. |
Base commit: dfe42d6 |
Base commit: dfe42d6 |
|
This pull request has been merged in 52b0cc0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff refactors the
prepareBoosttask to a separate Gradle task in the.internalpackage.The reason for this change is that
prepareBoostwas defining adoLastaction and would result in beinginvalidated whenever the
build.gradlefile would change. This means that the Boost headers/source fileswould have been extracted again, effectively invalidating the timestamps for the native build.
Changelog:
[Internal] [Changed] - Export prepareBoost to an internal task
Reviewed By: ShikaSD
Differential Revision: D31662120