Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give barTintColor and titleTextColor to the RCTNavigatorIem #318

Closed
wants to merge 1 commit into from
Closed

Give barTintColor and titleTextColor to the RCTNavigatorIem #318

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 27, 2015

Resolves #273, and also another bug regarding the titleTextColor.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@AbeEstrada
Copy link

👍 I hope this get merged soon.

This was referenced Mar 29, 2015
Closed
Closed
@nim23
Copy link

nim23 commented Mar 29, 2015

Just a heads up, for some reason providing the barTintColor, void's the tintColor and is always blue. I made the same changes as this commit to my local copy of react-native and as soon as I provide a barTintColor, tintColor is always blue.

@harrywincup
Copy link

tintColor seems to be intentionally disabled if barTintColor is present, though i'm not sure why?

react-native/React/Views/RCTWrapperViewController.m

Line 80 in 72d3d72

BOOL canSetTintColor = _navItem.barTintColor == nil;

@torifat
Copy link

torifat commented Mar 30, 2015

The alpha value on barTintColor doesn't have any effect on the navigation bar. It seems using a transparent image as background is the current solution. I'm naive to iOS development. So, any expert can correct me if I'm wrong. But, I believe they have not implemented it intentionally - https://github.com/facebook/react-native/blob/master/Libraries/Components/Navigation/NavigatorIOS.ios.js#L47

@vjeux
Copy link
Contributor

vjeux commented Apr 3, 2015

There are trailing whitespaces. Also, can you make use of those in the NavigatorIOSExample?

@eduardinni eduardinni mentioned this pull request Apr 6, 2015
Closed
@eduardinni
Copy link
Contributor

I completed this pull request, based on all your comments here. I include one working example.

I don't know if it is possible to merge pull requests, but mine is #695

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 7, 2015
sahrens pushed a commit to sahrens/react-native that referenced this pull request Apr 24, 2015
@eduardinni
NavigatorIOS custom nav bar colors
aa3d343 
Summary:
NavigatorIOS with custom nav bar custom colors, working example included in
UIExplorer.

Based on pull request facebook#318 to complete pending work based on comments.
Closes facebook#695
Github Author: Eduardo <[email protected]>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
@brentvatne
Copy link
Collaborator

This was merged!

@brentvatne brentvatne closed this May 30, 2015
jfrolich pushed a commit to jfrolich/react-native that referenced this pull request Apr 22, 2020
@MoOx @czystyl
Fixup js output for 9bc1d32 (because of 3081fac) (facebook#318)
07dba20 
facebook#307 made the js generated by facebook#305 incorrect.
This PR fixes that.
mganandraj pushed a commit to mganandraj/react-native that referenced this pull request May 4, 2020
@alloy
[generator-macos] Setup Podfile for platform specificity during auto-…
8cb99cd 
…linking (facebook#318)

See react-native-community/cli#1126
ayushjainrksh referenced this pull request in MLH-Fellowship/react-native Jul 2, 2020
@orta @charpeni
Add a note about CPFRN in the troubleshooting next to the other CP is…
d455387 
…sues (#318)
ayushjainrksh referenced this pull request in MLH-Fellowship/react-native Jul 2, 2020
@charpeni
Revert "Update native-modules-ios.md" (#328)
e32be69 
* Revert "Add a note about CPFRN in the troubleshooting next to the other CP issues (#318)"

This reverts commit d455387.

* Revert "Update getting-started.md (#315)"

This reverts commit 2730f0e.

* Revert "Update native-modules-ios.md (#306)"

This reverts commit 70265d7.
@bumplzz69 bumplzz69 mentioned this pull request Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

You can't set barTintColor on NavigatoriOS
8 participants
@facebook-github-bot @AbeEstrada @nim23 @harrywincup @torifat @vjeux @eduardinni @brentvatne