Pressable ripple should pick press event coordinates on subsequent press. #31669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 3827ca6 |
Base commit: 3827ca6 |
|
@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 7, 2021
…#31777) Summary: TouchableNativeFeedback's ripple starts from previous location on subsequent presses. This is similar to #31669 Fixes #28944 Issue https://user-images.githubusercontent.com/23293248/123521731-1f375f00-d6d6-11eb-8e4c-fc5ffb322e67.mov Fix https://user-images.githubusercontent.com/23293248/123521735-2bbbb780-d6d6-11eb-88b2-be75342cf22a.mov ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Fixed] - TouchableNativeFeedback ripple starts on previous touch location. Pull Request resolved: #31777 Test Plan: Tested TouchableNativeFeedback examples in rn-tester app. Registering coordinates before pressed command fixes the issue. Reviewed By: lunaleaps Differential Revision: D29496515 Pulled By: kacieb fbshipit-source-id: 77ac626181a61eee2cd30c4d48e52d10d800f2d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Please watch the recording below for better explanation. Ripple effect starts from previous press event's coordinates on subsequent presses.
120929621-58983280-c707-11eb-8055-eb52d1920877.mov
Changelog
[Android] [Fixed] - Pressable ripple subsequent press coordinates.
Test Plan
Screen.Recording.2021-06-06.at.8.48.05.PM.mov