Fix image loop counter on iOS 14

[comvenger-brandon]

Summary

Animated gifs, which do not loop, currently animate twice on iOS 14.
See: #30147

Changelog

[iOS] [Fixed] - Animated images without loop no longer animate twice

Test Plan

Run the example app with any animated gif. I attached a gif, which is affected.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 65975dd

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,898,018	-1,550
android	hermes	armeabi-v7a	8,402,326	-605
android	hermes	x86	9,384,334	-1,491
android	hermes	x86_64	9,329,699	-1,614
android	jsc	arm64-v8a	10,349,881	-1,548
android	jsc	armeabi-v7a	9,837,272	-624
android	jsc	x86	10,397,699	-1,497
android	jsc	x86_64	10,983,322	-1,603

Base commit: 65975dd

[mrousavy]

"repeat twice" is misleading imo, it doesn't "repeat" twice, it "plays" twice - right?

[comvenger-brandon]

"repeat twice" is misleading imo, it doesn't "repeat" twice, it "plays" twice - right?

Yup, correct. Did I write „repeat twice“ somewhere? :o

[mrousavy]

@comvenger-brandon no, I'm just referring to this comment, maybe you can change that as well :)

[comvenger-brandon]

@comvenger-brandon no, I'm just referring to this comment, maybe you can change that as well :)

Ah, you're right. Let's just change that as well, while we're at it.

[PeteTheHeat]

Just so I understand clearly, previously:

A gif that should loop once would go twice.
A gif that should loop twice would go three times.

With this fix, infinite loops still work, and gifs that go once/twice/thrice go the correct number of times.

[facebook-github-bot]

@PeteTheHeat has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[comvenger-brandon]

Just so I understand clearly, previously:

A gif that should loop once would go twice.
A gif that should loop twice would go three times.

With this fix, infinite loops still work, and gifs that go once/twice/thrice go the correct number of times.

Correct.

[facebook-github-bot]

@PeteTheHeat merged this pull request in 17aa1e3.

[DheerajGussain]

if(@available(iOS 14, *)) {
} else {
// A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
if (loopCount != 0) {
loopCount++;
}
}

after using the above code, still gif animating twice

[henninghh990]

if(@available(iOS 14, *)) {
} else {
// A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
if (loopCount != 0) {
loopCount++;
}
}

after using the above code, still gif animating twice

Same for me

[comvenger-brandon]

Care to share the gif file in question? I will have a look.
And just to be sure: you guys are testing on iOS14?

[henninghh990]

Care to share the gif file in question? I will have a look.
And just to be sure: you guys are testing on iOS14?

iOS 14.4

[DheerajGussain]

Screen.Recording.2021-02-16.at.8.24.35.PM.mov

Care to share the gif file in question? I will have a look.
And just to be sure: you guys are testing on iOS14?

yes it's 14.4
attaching the gif file which used antimate once only before ios 14 and there is another video which shows the current behaviour on app

[comvenger-brandon]

Care to share the gif file in question? I will have a look.
And just to be sure: you guys are testing on iOS14?

iOS 14.4

The shared image only plays once when I test it on iOS 14.4 (iPhone 12).

Are you sure you correctly applied the patch (via patch-package for example)? This change is not yet live in RN stable.

[DheerajGussain]

Care to share the gif file in question? I will have a look.
And just to be sure: you guys are testing on iOS14?

iOS 14.4

The shared image only plays once when I test it on iOS 14.4 (iPhone 12).

Are you sure you correctly applied the patch (via patch-package for example)? This change is not yet live in RN stable.

hey can you explain how to do that, iam using expo on my project

[henninghh990]

Care to share the gif file in question? I will have a look.
And just to be sure: you guys are testing on iOS14?

iOS 14.4

The shared image only plays once when I test it on iOS 14.4 (iPhone 12).

Are you sure you correctly applied the patch (via patch-package for example)? This change is not yet live in RN stable.

Yes, I applied it.
But whatever I do in this file, Expo doesn't "Refresh" automaticly, and even if I write something that would crash the app, nothig happens. It's like this file isn't included or something.

EDIT: I'm using managed workflow, if that can affect this