Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include android in npm package #30451

Closed
wants to merge 1 commit into from

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Nov 21, 2020

Summary

RN app expects android folder with maven artifacts in NPM package, and test-manual-e2e.sh fails on 0.64-stable because it couldn't find android folder, therefore looks into remote repos and finds 0.20.1 version on bintray.

See

url("$rootDir/../node_modules/react-native/android")

This PR will change npm pack to include android folder with maven artifacts in NPM package, thus RN android apps can find RN in node_modules.

Changelog

[Internal] [Changed] - include android in npm package

Test Plan

With this change test-manual-e2e.sh will run successfully, previous it was failing due to duplicate classes error.

@dulmandakh dulmandakh requested a review from fkgozali November 21, 2020 09:21
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Nov 21, 2020
@pull-bot
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 8540b2b

@dulmandakh
Copy link
Contributor Author

it was removed in 223ac43

@dulmandakh
Copy link
Contributor Author

@grabbou @kelset @alloy please cherry pick this into 0.64 branch 👍

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry about that, I updated the list based on the directories in the repo.

@cpojer
Copy link
Contributor

cpojer commented Nov 21, 2020

I can merge this at fb but we all have a week off. I recommend picking this to the release branch before it is merged to master.

@dulmandakh
Copy link
Contributor Author

Ah sorry about that, I updated the list based on the directories in the repo.

you're welcome

@alloy
Copy link
Contributor

alloy commented Nov 21, 2020

Yup, I’ll pick and push it manually, I’m not authorized to merge PRs 👍

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @dulmandakh in 0675bee.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants