-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include android in npm package #30451
Conversation
it was removed in 223ac43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry about that, I updated the list based on the directories in the repo.
I can merge this at fb but we all have a week off. I recommend picking this to the release branch before it is merged to master. |
you're welcome |
Yup, I’ll pick and push it manually, I’m not authorized to merge PRs 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @dulmandakh in 0675bee. When will my fix make it into a release? | Upcoming Releases |
Summary
RN app expects android folder with maven artifacts in NPM package, and test-manual-e2e.sh fails on 0.64-stable because it couldn't find android folder, therefore looks into remote repos and finds 0.20.1 version on bintray.
See
react-native/template/android/build.gradle
Line 27 in e99b8bb
This PR will change npm pack to include android folder with maven artifacts in NPM package, thus RN android apps can find RN in node_modules.
Changelog
[Internal] [Changed] - include android in npm package
Test Plan
With this change test-manual-e2e.sh will run successfully, previous it was failing due to duplicate classes error.