Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node version to >= 12 #30252

Closed
wants to merge 21 commits into from
Closed

Update Node version to >= 12 #30252

wants to merge 21 commits into from

Conversation

safaiyeh
Copy link
Contributor

Summary

Update engines to node >= 12

Changelog

[General] [Changed] - Update node engine to version 12

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 27, 2020
@safaiyeh
Copy link
Contributor Author

cc @hramos

@pull-bot
Copy link

pull-bot commented Oct 27, 2020

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against ef21ae4

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cpojer
Copy link
Contributor

cpojer commented Oct 27, 2020

It looks like at least some CI steps are still using node 10. Could you update those?

@safaiyeh
Copy link
Contributor Author

It looks like at least some CI steps are still using node 10. Could you update those?

Sounds good, I'll check it out tomorrow.

@safaiyeh
Copy link
Contributor Author

safaiyeh commented Oct 27, 2020

Had to update to the latest docker-android to support Node >= 12, which also requires updating to Android SDK 21.

There is currently an open issue here: react-native-community/docker-android#93 concerning the AVD which is breaking test_android

Will see if I can fix it on that end

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 36b0f7d

@safaiyeh
Copy link
Contributor Author

safaiyeh commented Oct 27, 2020

docker-android also seems to be missing JAVA_HOME as well

Made PR here: react-native-community/docker-android#97

Copy link
Contributor

@hramos hramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Copy link
Contributor

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like .nvmrc can also be removed. LGTM.

@gengjiawen
Copy link
Contributor

You missed .circleci/Dockerfiles/Dockerfile.android.

@safaiyeh
Copy link
Contributor Author

Made

You missed .circleci/Dockerfiles/Dockerfile.android.

Appreciate it! updated that

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@fkgozali
Copy link
Contributor

Hmm, the test_android/test_docker are still failing, are we missing something?

@gengjiawen
Copy link
Contributor

Hmm, the test_android/test_docker are still failing, are we missing something?

Looks buck config get wrong

Step 14/24 : RUN buck fetch ReactAndroid/src/test/java/com/facebook/react/modules
 ---> Running in 3ea762ab4fe4
Not using buckd because watchman isn't installed.
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
PARSING BUCK FILES: FINISHED IN 4.3s
No build file at Libraries/BUCK when resolving target //Libraries:generated_java_modules-FBReactNativeSpec.

@safaiyeh safaiyeh changed the title Update Node version in package.json Update Node version to >= 12 Oct 29, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @safaiyeh in 4b92e2e.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants