-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node version to >= 12 #30252
Update Node version to >= 12 #30252
Conversation
cc @hramos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
It looks like at least some CI steps are still using node 10. Could you update those? |
Sounds good, I'll check it out tomorrow. |
Had to update to the latest There is currently an open issue here: react-native-community/docker-android#93 concerning the AVD which is breaking test_android Will see if I can fix it on that end |
Base commit: 36b0f7d |
docker-android also seems to be missing JAVA_HOME as well Made PR here: react-native-community/docker-android#97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like .nvmrc
can also be removed. LGTM.
You missed |
Made
Appreciate it! updated that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Hmm, the test_android/test_docker are still failing, are we missing something? |
Looks buck config get wrong Step 14/24 : RUN buck fetch ReactAndroid/src/test/java/com/facebook/react/modules
---> Running in 3ea762ab4fe4
Not using buckd because watchman isn't installed.
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
PARSING BUCK FILES: FINISHED IN 4.3s
No build file at Libraries/BUCK when resolving target //Libraries:generated_java_modules-FBReactNativeSpec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @safaiyeh in 4b92e2e. When will my fix make it into a release? | Upcoming Releases |
Summary
Update engines to node >= 12
Changelog
[General] [Changed] - Update node engine to version 12
Test Plan