Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android][Flatlist] Fix last item removal scroll position #28977

Closed
wants to merge 1 commit into from
Closed

[Android][Flatlist] Fix last item removal scroll position #28977

wants to merge 1 commit into from

Conversation

jayshah123
Copy link
Contributor

Summary

Currently on Android, when last item in a horizontal flatlist is removed, scroll position does not update.

Fixes #27504

Changelog

[Android] [Changed] - HorizontalScrollView last item removal will adjust scroll position

Test Plan

This is the same code which is being used and already proven for vertical scrollview.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 26, 2020
@jayshah123 jayshah123 changed the title Fix last item removal scroll position [Android]Fix last item removal scroll position May 26, 2020
@jayshah123 jayshah123 changed the title [Android]Fix last item removal scroll position [Android][Flatlist] Fix last item removal scroll position May 26, 2020
@jayshah123 jayshah123 mentioned this pull request May 26, 2020
Closed
@react-native-bot react-native-bot added the Platform: Android Android applications. label May 26, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,780,314 36
android hermes armeabi-v7a 6,442,550 21
android hermes x86 7,165,437 47
android hermes x86_64 7,056,103 39
android jsc arm64-v8a 8,948,117 40
android jsc armeabi-v7a 8,602,741 29
android jsc x86 8,776,335 26
android jsc x86_64 9,352,644 40

Base commit: 60b7a30

@analysis-bot
Copy link

analysis-bot commented May 26, 2020 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal 809,568 0

Base commit: 60b7a30

sanduluca
sanduluca approved these changes Jul 1, 2021
View reviewed changes
Copy link

@sanduluca sanduluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me.

@jayshah123
Copy link
Contributor Author

will re-raise this after some due diligence.

@jayshah123 jayshah123 closed this Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanduluca sanduluca sanduluca approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android][Flatlist][Horizontal] Last item delete in horizontal flatlist does not adjust scroll position.
5 participants
@jayshah123 @analysis-bot @sanduluca @facebook-github-bot @react-native-bot