-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: exclude ReactNativeFlipper.java from release build #28257
Conversation
Hi @acro5piano! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
RNTester.app (iOS): 10715136 bytes |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Hi @acro5piano ReactNativeFlipper should be in your debug config. https://github.com/facebook/react-native/tree/master/template/android/app/src/debug/java/com/helloworld Notice the directory Could you demonstrate this happens with a fresh template, if it doesn't there it is an issue with your project's setup. |
@safaiyeh Ah okay, I'll check it later! |
Sorry for the delay, but I confirmed my project and move ReactNativeFlipper.java from |
Summary
Exclude
ReactNativeFlipper.java
from build files in release build.I faced a lot of errors like
com.facebook.flipper.*** does not exist
during./gradlew assembleRelease
(see a screenshot below) and it prevents creating release apk file. I think this is because we build java sources of Flipper asdebugImplementation
.Changelog
[Android] [Changed] - exclude ReactNativeFlipper.java from release build
Test Plan
./assembleRelease
works.I think #28052 might effect this modification of template file.