[template] Resolve localization warnings #28046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
6 tasks
|
Hi @hramos, status on this? Hopefully we can get it merged and picked into 0.62 |
5 tasks
|
This pull request was successfully merged by @safaiyeh in 0e4bcaa. When will my fix make it into a release? | Upcoming Releases |
alloy
pushed a commit
that referenced
this pull request
Feb 25, 2020
Summary: Resolve Xcode localization warnings in template ## Changelog [iOS] [Fixed] - Resolve localization warnings Pull Request resolved: #28046 Test Plan: Create a fresh template app, localization warnings should not happen. Differential Revision: D19873686 Pulled By: hramos fbshipit-source-id: 5db0e7da1048899c4049fe991bc354a6798dfb06
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Resolve Xcode localization warnings in template ## Changelog [iOS] [Fixed] - Resolve localization warnings Pull Request resolved: facebook#28046 Test Plan: Create a fresh template app, localization warnings should not happen. Differential Revision: D19873686 Pulled By: hramos fbshipit-source-id: 5db0e7da1048899c4049fe991bc354a6798dfb06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve Xcode localization warnings in template
Changelog
[iOS] [Fixed] - Resolve localization warnings
Test Plan
Create a fresh template app, localization warnings should not happen.