Use autolink script in template on iOS #27984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
janicduplessis
commented
Feb 7, 2020
| @@ -43,7 +43,7 @@ def use_react_native! (options={}) | |||
| pod 'React-jsinspector', :path => "#{prefix}/ReactCommon/jsinspector" | |||
| pod 'ReactCommon/callinvoker', :path => "#{prefix}/ReactCommon" | |||
| pod 'ReactCommon/turbomodule/core', :path => "#{prefix}/ReactCommon" | |||
| pod 'Yoga', :path => "#{prefix}/ReactCommon/yoga" | |||
| pod 'Yoga', :path => "#{prefix}/ReactCommon/yoga", :modular_headers => true | |||
There was a problem hiding this comment.
Updated this to match what was in the template before.
react-native-bot
added
Platform: iOS
facebook-github-bot
approved these changes
Feb 7, 2020
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @janicduplessis in a35efb9. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: We use this for RN tester but it is not currently included in npm releases. It cleans up the podfile a lot and will make adding / removing pods easier in the future since it won't require users to update their project. ## Changelog [iOS] [Added] - Use autolink script in template on iOS Pull Request resolved: facebook#27984 Test Plan: Not sure if there is a way to end to end test this but I've been using this autolink script in my fork for a while. Differential Revision: D19787729 Pulled By: cpojer fbshipit-source-id: b843ea723085830f13e8f0149833d1beb1efdfac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We use this for RN tester but it is not currently included in npm releases. It cleans up the podfile a lot and will make adding / removing pods easier in the future since it won't require users to update their project.
Changelog
[iOS] [Added] - Use autolink script in template on iOS
Test Plan
Not sure if there is a way to end to end test this but I've been using this autolink script in my fork for a while.