Make addCookies method public. #27512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cpojer |
facebook-github-bot
added
the
CLA Signed
|
+1 |
cpojer
approved these changes
Dec 27, 2019
facebook-github-bot
approved these changes
Dec 27, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @safaiyeh in cc845cc. When will my fix make it into a release? | Upcoming Releases |
|
@cpojer Thank You! |
alloy
pushed a commit
that referenced
this pull request
Feb 13, 2020
Summary: react-native-cookie-store wants the ability to set custom cookies on Android. We use ForwardingCookieHandler to mange the cookies. Exposing the `addCookies` method will allow the module to provide the same functionality on Android. safaiyeh/react-native-cookie-store#1 ## Changelog [Android] [Changed] - Expose addCookies method Pull Request resolved: #27512 Test Plan: N/A Differential Revision: D19236309 Pulled By: cpojer fbshipit-source-id: bf1a0730165456c34c5bf432ac370176a881cbcf
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: react-native-cookie-store wants the ability to set custom cookies on Android. We use ForwardingCookieHandler to mange the cookies. Exposing the `addCookies` method will allow the module to provide the same functionality on Android. safaiyeh/react-native-cookie-store#1 ## Changelog [Android] [Changed] - Expose addCookies method Pull Request resolved: facebook#27512 Test Plan: N/A Differential Revision: D19236309 Pulled By: cpojer fbshipit-source-id: bf1a0730165456c34c5bf432ac370176a881cbcf
KusStar
pushed a commit
to KusStar/react-native
that referenced
this pull request
Nov 2, 2020
Summary: react-native-cookie-store wants the ability to set custom cookies on Android. We use ForwardingCookieHandler to mange the cookies. Exposing the `addCookies` method will allow the module to provide the same functionality on Android. safaiyeh/react-native-cookie-store#1 ## Changelog [Android] [Changed] - Expose addCookies method Pull Request resolved: facebook#27512 Test Plan: N/A Differential Revision: D19236309 Pulled By: cpojer fbshipit-source-id: bf1a0730165456c34c5bf432ac370176a881cbcf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
react-native-cookie-store wants the ability to set custom cookies on Android. We use ForwardingCookieHandler to mange the cookies. Exposing the
addCookiesmethod will allow the module to provide the same functionality on Android.safaiyeh/react-native-cookie-store#1
Changelog
[Android] [Changed] - Expose addCookies method
Test Plan
N/A